Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved: Added a flag to prevent auto-population of the facility ID after it has been manually edited(#265) #326

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Improved: Added a flag to prevent auto-population of the facility ID after it has been manually edited(#265) #326

merged 3 commits into from
Nov 21, 2024

Conversation

R-Sourabh
Copy link
Contributor

Related Issues

#265

Short Description and Why It's Useful

  • Added a check to prevent auto-population of the facilityId and facilityGroupId after manual edits, as they were previously auto-populated after every facilityName update.

Contribution and Currently Important Rules Acceptance

ymaheshwari1
ymaheshwari1 requested changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@ymaheshwari1 ymaheshwari1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handle this change when creating virtual facility as well.

@ravilodhi ravilodhi merged commit 17340e7 into hotwax:main Nov 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymaheshwari1 ymaheshwari1 ymaheshwari1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@R-Sourabh @ymaheshwari1 @ravilodhi