Implemented: flow to create facility #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravilodhi
reviewed
Nov 28, 2023
src/services/UserService.ts
Outdated
| @@ -136,8 +136,26 @@ const getUserProfile = async (token: any): Promise<any> => { | |||
| } | |||
| } | |||
|
|
|||
| const createFacilityLogin = async (payload: any): Promise <any> => { | |||
There was a problem hiding this comment.
Rename this to createFacilityUser as we are not creating userLogin here.
ravilodhi
reviewed
Nov 28, 2023
| @@ -146,6 +146,46 @@ const actions: ActionTree<FacilityState, RootState> = { | |||
| commit(types.FACILITY_CURRENT_UPDATED, facility) | |||
| }, | |||
|
|
|||
| async fetchCreatedFacility({ commit, state }, payload) { | |||
There was a problem hiding this comment.
There should already be some action to fetch facility details, as we already fetching facility details on the detail page.
ravilodhi
reviewed
Nov 28, 2023
| } | ||
|
|
||
| emitter.emit("dismissLoader"); | ||
| commit(types.FACILITY_CREATED_UPDATED, facility); |
There was a problem hiding this comment.
I think no need to maintain a separate state we can use the same state that is used to store/fetch selected facility on the detail page?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #
Short Description and Why It's Useful
Screenshots of Visual Changes before/after (If There Are Any)
Contribution and Currently Important Rules Acceptance