Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved: clearing gitbook search modal queries on modal dismiss and promise for fetching resources (#313) #314

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

amansinghbais
Copy link
Contributor

Related Issues

#313

Short Description and Why It's Useful

  • Clearing query state of gitbook search modal to have clear console on reopening.
  • Used Promise.allSettled to fetch all resources even if one api fails.

Screenshots of Visual Changes before/after (If There Are Any)

Is the changes contains any breaking change?

If there are any breaking change include those in the release notes file

  • Yes
  • No

Contribution and Currently Important Rules Acceptance

@ymaheshwari1 ymaheshwari1 merged commit 23d3b96 into hotwax:main Jul 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants