Improved: usage of ion-select as per the changes in ionic7(#244)

hotwax · Jan 5, 2024 · e0580b9 · e0580b9
1 parent 4cdc99e
commit e0580b9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/src/components/LanguageSwitcher.vue b/src/components/LanguageSwitcher.vue
@@ -9,8 +9,7 @@
       {{ $t('Select your preferred language.') }}
     </ion-card-content>
     <ion-item lines="none">
-      <ion-label>{{ $t("Choose language") }}</ion-label>
-      <ion-select interface="popover" :value="currentLocale" @ionChange="setLocale($event.detail.value)">
+      <ion-select :label="$t('Choose language')" interface="popover" :value="currentLocale" @ionChange="setLocale($event.detail.value)">
         <ion-select-option v-for="locale in Object.keys(locales)" :key="locale" :value="locale">{{ locales[locale] }}</ion-select-option>
       </ion-select>
     </ion-item>

diff --git a/src/components/ProductIdentifier.vue b/src/components/ProductIdentifier.vue
@@ -12,14 +12,12 @@
     </ion-card-content>
 
     <ion-item>
-      <ion-label>{{ "Primary Product Identifier" }}</ion-label>
-      <ion-select interface="popover" :placeholder="'primary identifier'" :value="productIdentificationPref.primaryId" @ionChange="setProductIdentificationPref($event.detail.value, 'primaryId')">
+      <ion-select :label="$t('Primary Product Identifier')" interface="popover" :placeholder="'primary identifier'" :value="productIdentificationPref.primaryId" @ionChange="setProductIdentificationPref($event.detail.value, 'primaryId')">
         <ion-select-option v-for="identification in productIdentificationOptions" :key="identification" :value="identification" >{{ identification }}</ion-select-option>
       </ion-select>
     </ion-item>
     <ion-item>
-      <ion-label>{{ "Secondary Product Identifier" }}</ion-label>
-      <ion-select interface="popover" :placeholder="'secondary identifier'" :value="productIdentificationPref.secondaryId" @ionChange="setProductIdentificationPref($event.detail.value, 'secondaryId')">
+      <ion-select :label="$t('Secondary Product Identifier')" interface="popover" :placeholder="'secondary identifier'" :value="productIdentificationPref.secondaryId" @ionChange="setProductIdentificationPref($event.detail.value, 'secondaryId')">
         <ion-select-option v-for="identification in productIdentificationOptions" :key="identification" :value="identification" >{{ identification }}</ion-select-option>
         <ion-select-option value="">{{ "None" }}</ion-select-option>
       </ion-select>