-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented: in-app notifications state and UI #279
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nPreferences action
…nitial and final values are same and removed config entry values from env
ymaheshwari1
requested changes
Sep 19, 2023
1 task
ymaheshwari1
requested changes
Sep 21, 2023
ymaheshwari1
requested changes
Sep 21, 2023
…ode for enbaling/disbaling fab button
1 task
…ication icon colour
ymaheshwari1
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #274
Short Description and Why It's Useful
Implemented notifications system in-app instead of using DXP (only managed token registration there) as there were issues with DXP implementation while using Ionic components and with Pinia's reactivity.
Screenshots of Visual Changes before/after (If There Are Any)
Contribution and Currently Important Rules Acceptance