Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved rule condition generation template based on backend compatibility (#363) #364

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Improved rule condition generation template based on backend compatibility (#363) #364

merged 1 commit into from
Jul 23, 2024

Conversation

amansinghbais
Copy link
Contributor

Related Issues

#363

Short Description and Why It's Useful

  • Removed multiValued field from the ruleConditions.
  • Updated the ruleCondition operators from "in,not-in" to "contains,not-contains".

Screenshots of Visual Changes before/after (If There Are Any)

Contribution and Currently Important Rules Acceptance

@amansinghbais amansinghbais assigned ravilodhi and unassigned ravilodhi Jul 23, 2024
@amansinghbais amansinghbais requested a review from ravilodhi July 23, 2024 05:55
@ravilodhi ravilodhi merged commit c5c867e into hotwax:main Jul 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymaheshwari1 ymaheshwari1 Awaiting requested review from ymaheshwari1

@ravilodhi ravilodhi Awaiting requested review from ravilodhi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amansinghbais @ravilodhi