Implemented: functionality to the Publish segment of the Inventory channels page (#356) #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…clipboard action (hotwax#356)
ymaheshwari1
requested changes
Jul 8, 2024
…try for frequency options (hotwax#356)
ymaheshwari1
requested changes
Jul 9, 2024
| // checking if the runtimeData has productStoreId, and if present then adding it on root level | ||
| job?.runtimeData?.productStoreId?.length >= 0 && (payload['productStoreId'] = job.status === "SERVICE_PENDING" ? job.productStoreId : store.state.user.currentEComStore.productStoreId) | ||
| job?.priority && (payload['SERVICE_PRIORITY'] = job.priority.toString()) | ||
| job?.sinceId && (payload['sinceId'] = job.sinceId) |
There was a problem hiding this comment.
Remove this as its not used in this service.
src/store/modules/channel/actions.ts
Outdated
| @@ -70,6 +71,140 @@ const actions: ActionTree<ChannelState, RootState> = { | |||
| commit(types.CHANNEL_INVENTORY_CHANNELS_UPDATED, groups); | |||
| }, | |||
|
|
|||
| async fetchShopifyConfigs ({ commit }) { | |||
There was a problem hiding this comment.
commit is defined but not used.
| return shopifyConfigs; | ||
| }, | ||
|
|
||
| async fetchJobs ({ commit, dispatch }) { |
There was a problem hiding this comment.
Fetch jobs and configs again on changing productStore
There was a problem hiding this comment.
Its already handled in the code.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#356
Short Description and Why It's Useful
Added functionality in the Publish segment of the inventory channels page.
Screenshots of Visual Changes before/after (If There Are Any)
Contribution and Currently Important Rules Acceptance