Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Hidden item-divider when Channels are not found and Moved channel options at last of the list(#228) #230

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Fixed: Hidden item-divider when Channels are not found and Moved channel options at last of the list(#228) #230

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62798a0
Fixed: Hidden item-divider when channels are not found(#228)
shanmukhdutt Jan 8, 2024
2fdddd4
Improved Item-divider
shanmukhdutt Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/views/ScheduleThreshold.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,6 @@
<ion-icon :icon="optionsOutline" slot="start" />
<ion-label>{{ threshold }} {{ $t('threshold') }}</ion-label>
</ion-item>
<ion-item-divider color="light">
<ion-label>{{ $t('Channels') }}</ion-label>
</ion-item-divider>
<ion-item v-for="channel in channels" :key="channel.facilityGroupId">
<ion-label>{{ channel?.facilityGroupName }}</ion-label>
<ion-toggle :checked="isChannelChecked(channel.facilityGroupId)" :disabled="isChannelDisabled(channel.facilityGroupId)" slot="end" @ionChange="updateChannels($event, channel.facilityGroupId)"/>
</ion-item>
<ion-item>
<ion-label color="medium">{{ $t("Name") }}</ion-label>
<ion-input :placeholder="$t('rule name')" v-model="jobName"/>
Expand All @@ -50,6 +43,13 @@
</ion-content>
</ion-modal>
</ion-item>
<ion-item-divider v-if="channels.length" color="light">
<ion-label>{{ $t('Channels') }}</ion-label>
</ion-item-divider>
<ion-item v-for="channel in channels" :key="channel.facilityGroupId">
<ion-label>{{ channel?.facilityGroupName }}</ion-label>
<ion-toggle :checked="isChannelChecked(channel.facilityGroupId)" :disabled="isChannelDisabled(channel.facilityGroupId)" slot="end" @ionChange="updateChannels($event, channel.facilityGroupId)"/>
</ion-item>
</ion-list>
</aside>

Expand Down
Loading