Skip to content

Commit

Permalink
Merge pull request #230 from shanmukhdutt/threshold-managment/#228
Browse files Browse the repository at this point in the history
Fixed: Hidden item-divider when Channels are not found and Moved channel options at last of the list(#228)
  • Loading branch information
ymaheshwari1 authored Jan 10, 2024
2 parents 3c5c3d9 + 2fdddd4 commit cbfd353
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions src/views/ScheduleThreshold.vue
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,6 @@
<ion-icon :icon="optionsOutline" slot="start" />
<ion-label>{{ threshold }} {{ $t('threshold') }}</ion-label>
</ion-item>
<ion-item-divider color="light">
<ion-label>{{ $t('Channels') }}</ion-label>
</ion-item-divider>
<ion-item v-for="channel in channels" :key="channel.facilityGroupId">
<ion-label>{{ channel?.facilityGroupName }}</ion-label>
<ion-toggle :checked="isChannelChecked(channel.facilityGroupId)" :disabled="isChannelDisabled(channel.facilityGroupId)" slot="end" @ionChange="updateChannels($event, channel.facilityGroupId)"/>
</ion-item>
<ion-item>
<ion-label color="medium">{{ $t("Name") }}</ion-label>
<ion-input :placeholder="$t('rule name')" v-model="jobName"/>
Expand All @@ -50,6 +43,13 @@
</ion-content>
</ion-modal>
</ion-item>
<ion-item-divider v-if="channels.length" color="light">
<ion-label>{{ $t('Channels') }}</ion-label>
</ion-item-divider>
<ion-item v-for="channel in channels" :key="channel.facilityGroupId">
<ion-label>{{ channel?.facilityGroupName }}</ion-label>
<ion-toggle :checked="isChannelChecked(channel.facilityGroupId)" :disabled="isChannelDisabled(channel.facilityGroupId)" slot="end" @ionChange="updateChannels($event, channel.facilityGroupId)"/>
</ion-item>
</ion-list>
</aside>

Expand Down

0 comments on commit cbfd353

Please sign in to comment.