Reverted: unused job parameter 'SinceId' and unused commit argument i…

…n action (#356)
hotwax · Jul 10, 2024 · 1ada9be · 1ada9be
1 parent bb9d535
commit 1ada9be
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 4 deletions.
diff --git a/src/components/ShopActionsPopover.vue b/src/components/ShopActionsPopover.vue
@@ -163,7 +163,6 @@ async function runServiceNow(job: any) {
   // checking if the runtimeData has productStoreId, and if present then adding it on root level
   job?.runtimeData?.productStoreId?.length >= 0 && (payload['productStoreId'] = job.status === "SERVICE_PENDING" ? job.productStoreId : store.state.user.currentEComStore.productStoreId)
   job?.priority && (payload['SERVICE_PRIORITY'] = job.priority.toString())
-  job?.sinceId && (payload['sinceId'] = job.sinceId)
 
   // ShopifyConfig and ShopifyShop should be set based upon runtime data
   // If existing job is run now, copy as is else set the current shop of user

diff --git a/src/store/modules/channel/actions.ts b/src/store/modules/channel/actions.ts
@@ -71,7 +71,7 @@ const actions: ActionTree<ChannelState, RootState> = {
     commit(types.CHANNEL_INVENTORY_CHANNELS_UPDATED, groups);
   },
 
-  async fetchShopifyConfigs ({ commit }) {
+  async fetchShopifyConfigs () {
     let shopifyConfigs = [];
 
     try {

diff --git a/src/views/InventoryChannels.vue b/src/views/InventoryChannels.vue
@@ -449,7 +449,6 @@ async function scheduleService(job: any) {
   job?.runtimeData?.productStoreId?.length >= 0 && (payload['productStoreId'] = job.productStoreId)
   job?.priority && (payload['SERVICE_PRIORITY'] = job.priority.toString())
   job?.runTime && (payload['SERVICE_TIME'] = job.runTime.toString())
-  job?.sinceId && (payload['sinceId'] = job.sinceId)
 
   try {
     resp = await ChannelService.scheduleJob({ ...payload });
@@ -479,7 +478,6 @@ async function updateJob(job: any) {
   } as any
 
   job?.runTime && (payload['runTime'] = job.runTime)
-  job?.sinceId && (payload['sinceId'] = job.sinceId)
   job?.jobName && (payload['jobName'] = job.jobName)
 
   try {