Remove trailing slashes from endpoints, fix check_access for backend roles #1893
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Describe this PR
Trailing slashes, Origin header, and CORS:
/route/
and/route
- they are different./route
-->/route/
, which was causing theOrigin
request header to be stripped in Firefox. As a result, withOrigin: null
the CORS check could not complete, so we get a CORS error.Fixes check_access logic:
project_roles
dict to correctly return when user details are returned from the APIs.Checklist before requesting a review
[optional] What gif best describes this PR or how it makes you feel?