fixes: Remove auth bypass in for HOTOSM org #1785

[Anuj-Gupta4]

What type of PR is this? (check all applicable)

• 🧑‍💻 Refactor

Related Issue

Example: Fixes #1785

Describe this PR

updated roles.check_access so it no longer grants access for hotosm

Checklist before requesting a review

• 📖 Read the FMTM Contributing Guide: https://github.com/hotosm/fmtm/blob/main/CONTRIBUTING.md
• 📖 Read the HOT Code of Conduct: https://docs.hotosm.org/code-of-conduct
• 👷‍♀️ Create small PRs. In most cases, this will be possible.
• ✅ Provide tests for your changes.
• 📝 Use descriptive commit messages.
• 📗 Update any related documentation and include any relevant screenshots.

[spwoodcock]

Looks good to me!

Did you manage to test out the endpoints when different permissions are set?

[spwoodcock]

Also, with the CI failing when using a forked repo, I probably need to rethink the setup! (no permission to push the built container image)

PRs probably shouldn't push the built image, but instead use a locally cached version for tests

[spwoodcock]

Looks good to me!

Did you manage to test out the endpoints when different permissions are set?

No time to test this thoroughly myself unfortunately - I trust you managed to give it a good test 🙏

Merging

[Anuj-Gupta4]

@spwoodcock There was an issue with organisation apis that was stopping me from testing. Sujan says he has fixed it.