-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace custom nginx / certbot config with BunkerWeb #1695
Draft
spwoodcock
wants to merge
16
commits into
development
Choose a base branch
from
build/bunkerweb
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
backend
Related to backend code
devops
Related to deployment or configuration
contrib
labels
Jul 23, 2024
spwoodcock
changed the title
Build/bunkerweb
Replace custom nginx / certbot config with BunkerWeb
Jul 23, 2024
spwoodcock
added
docs
Improvements or additions to documentation
and removed
documentation
labels
Aug 1, 2024
I've used a turnkey-like server solution Caddy before, but this seems like it's got even more and its security focused. Looks good to me. |
Thanks! I like that it reduces the maintenance burden for building nginx images with brotli and maintaining configs π Hoping to finish this at some point & also roll it out for DroneTM eventually too π |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related Issue
Fixes #1686
Also fixes #1479
Related to: #1650, but does not fix it.
(the FastAPI middleware is probably required after all)
Describe this PR
Bunkerweb repo: https://github.com/bunkerity/bunkerweb/
nginx
directory and related code / configs / scripts.development
andmain
compose configs.scheduler
and docker socket binding service. Thankfully I managed to get this to work as initialisation only, rather than running continuously.timeout 120
for each service allows the configs to generated and copied to the nginx webserver, then the scheduler and docker socket service shut down.Alternative Approaches Considered
Notes
docker compose down -v
Review Guide
Notes for the reviewer. How to test this change?
Checklist before requesting a review
[optional] What gif best describes this PR or how it makes you feel?