Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed duplicate __serialize and __unserialize #34

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

Schlue
Copy link
Contributor

@Schlue Schlue commented Apr 1, 2024

@ralflang the integration of one of the pull requested caused a duplicate of the new __serialize functions. This pull requests removed these functions.

Copy link

what-the-diff bot commented Apr 1, 2024

PR Summary

  • Update to .gitignore
    Added .vscode to the .gitignore file to prevent Visual Studio Code settings from being tracked in git.

  • Removal of serialization methods
    Consistently removed the __serialize and __unserialize methods across multiple classes in the Horde/Imap/Client directory. This change affects several files, including Base.php, Data/Acl.php, Data/AclRights.php, Data/Capability.php, Data/Envelope.php, Data/Namespace.php, Data/SearchCharset.php, Data/Thread.php, Ids.php, Ids/Map.php, Mailbox.php, Search/Query.php, Url.php and Url/Base.php. This cleanup simplifies the codebase by eliminating these unnecessary or redundant serialization functionalities.

Copy link
Member

@ralflang ralflang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we had a duplication between horde master efforts and maintaina-com/FRAMEWORK_6_0 efforts during the long time when both ran in parallel.

@ralflang ralflang merged commit 98a4ba5 into horde:FRAMEWORK_6_0 Apr 4, 2024
0 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants