Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: STORE for iCloud and other strict IMAP servers (master branch) #30

Merged

Conversation

miaulalala
Copy link
Contributor

Apple's iCloud IMAP server (and possibly others, although I haven't tested it) want brackets around any FLAG command params as shown in the examples of RFC3501.

If the brackets aren't added, the command fails with BAD Parse Error for the \Delete FLAG.

To fix this, wrap the params of a STORE command in a Horde_Imap_Client_Data_Format_List.

Otherwise, the \Delete FLAG, \Seen FLAG and possibly all other PERMFLAGs aren't added, even if the STORE command doesn't return a BAD response.

Apple's iCloud IMAP server (and possibly others, although I haven't tested it) want brackets around any
FLAG command params as shown in the examples of [RFC3501](https://datatracker.ietf.org/doc/html/rfc3501#section-6.4.6])
If the brackets aren't added, the command fails with BAD Parse Error
To fix this, wrap the params of a STORE command in a Horde_Imap_Client_Data_Format_List
Otherwise, the \Delete FLAG, \Seen FLAG and possibly all other PERMFLAGs aren't added, even if the
STORE command doesn't return a BAD response.

Signed-off-by: Anna Larch <[email protected]>
Copy link

what-the-diff bot commented Mar 12, 2024

PR Summary

  • Modification in lib/Horde/Imap/Client/Socket.php
    The way this program defines certain options has been altered. Now, instead of the old method, it uses a more advanced feature for defining these attributes. This modification is expected to improve both the effectiveness and performance of the program.

@ralflang
Copy link
Member

@mrubinsk You must decide if this is fit for master. For FRAMEWORK_6_0 I am running with it (see #31 )

@ralflang ralflang changed the title fix: STORE for iCloud and other strict IMAP servers fix: STORE for iCloud and other strict IMAP servers (master branch) Mar 28, 2024
@mrubinsk mrubinsk merged commit 16aba47 into horde:master Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants