fix: STORE for iCloud and other strict IMAP servers (master branch) #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apple's iCloud IMAP server (and possibly others, although I haven't tested it) want brackets around any FLAG command params as shown in the examples of RFC3501.
If the brackets aren't added, the command fails with
BAD Parse Error
for the\Delete
FLAG.To fix this, wrap the params of a STORE command in a
Horde_Imap_Client_Data_Format_List
.Otherwise, the
\Delete
FLAG,\Seen
FLAG and possibly all other PERMFLAGs aren't added, even if the STORE command doesn't return a BAD response.