fix(routes): GET /accounts/123?include=foobar (#218)

hoodiehq · Oct 23, 2016 · 7633f02 · 7633f02
1 parent 5932559
commit 7633f02
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/routes/accounts.js b/routes/accounts.js
@@ -126,6 +126,7 @@ function accountRoutes (server, options, next) {
       auth: false,
       validate: {
         headers: validations.sessionIdHeader,
+        query: validations.accountQuery,
         failAction: joiFailAction
       }
     },

diff --git a/tests/integration/routes/accounts/get-accounts-test.js b/tests/integration/routes/accounts/get-accounts-test.js
@@ -342,8 +342,16 @@ getServer(function (error, server) {
       })
     })
 
-    group.test('with ?include=foobar', {todo: true}, function (t) {
-      t.end()
+    group.test('with ?include=foobar', function (t) {
+      server.inject({
+        method: 'GET',
+        url: '/accounts/abc1234?include=foobar',
+        headers: headers
+      }, function (response) {
+        t.is(response.statusCode, 400, 'returns 400 status')
+        t.deepEqual(response.result.errors[0].detail, 'Allowed value for ?include is \'profile\'', 'returns error message')
+        t.end()
+      })
     })
 
     group.end()