Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exported Hook type in valibot and typebox validators #821

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

MathurAditya724
Copy link
Contributor

Copy link

changeset-bot bot commented Nov 11, 2024

🦋 Changeset detected

Latest commit: 8ccda57

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hono/typebox-validator Patch
@hono/valibot-validator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@yusukebe
Copy link
Member

Hi @MathurAditya724 !

Thank you for the PR. Looks good but we have to add changesets. Can you run yarn changeset on the top of this project? These will be patch changes.

@MathurAditya724
Copy link
Contributor Author

Done, please verify that I have correctly added the changeset.

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

@MathurAditya724

Thans! Merging now.

@yusukebe yusukebe merged commit 553112c into honojs:main Nov 12, 2024
2 checks passed
@github-actions github-actions bot mentioned this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants