fix(graphql-server): enhance type safety of RootResolvers and Options #201
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #198 (I'm not familiar with Pothos, so I'm not sure...)
Summary
This commit introduces more specific type annotations to the following modules:
RootResolvers
Options
Specifically, the same type parameters used in the definition of
Context
class were given to them:See: https://github.com/honojs/hono/blob/main/src/context.ts
Diff
To confirm, change
bun_test/index.test.ts
as follows (not included in the commit)Before
After