Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(zod-openapi): additional headers test for Authorization #192

Merged
merged 2 commits into from
Oct 10, 2023
Merged

test(zod-openapi): additional headers test for Authorization #192

merged 2 commits into from
Oct 10, 2023

Conversation

callumfrance
Copy link
Contributor

I was trying to figure out how Authorisation headers will work with this repository. I discovered that there is some interesting behaviour with the capitalisation, and as such have added a test into the package to note this behaviour as seen here.

Additionally, I have removed a duplicate dependency from the package.json as this is already listed as a full dependency. In most scenarios, having a package listed twice the the package.json file is erroneous - I am sure if this was intentional someone will let me know 🙂

@changeset-bot
Copy link

changeset-bot bot commented Oct 5, 2023

⚠️ No Changeset found

Latest commit: 7f2993f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@callumfrance callumfrance changed the title feat(zod-openapi): additional headers test for Authorization test(zod-openapi): additional headers test for Authorization Oct 5, 2023
@yusukebe
Copy link
Member

yusukebe commented Oct 7, 2023

Hi @callumfrance

Thank your the PR. Indeed, it would be nice to have a test for authorization or Authorization in this project!

I think we don't need route and routeWithAuth, just one. We can remove route and rename routeWithAuth to route. What do you think?

@callumfrance
Copy link
Contributor Author

@yusukebe I have merged the two routes together

@yusukebe
Copy link
Member

@callumfrance

Thanks! I'll merge it now!

@yusukebe yusukebe merged commit d2398a4 into honojs:main Oct 10, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants