Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wye msg ref release2 log #9

Open
wants to merge 9 commits into
base: messaging_refactor_release2nd
Choose a base branch
from

Conversation

intel-whye
Copy link
Collaborator

Issue Number:

Objective of pull request:

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

	code clean;
	add log file path option in setenv.sh, the default value is
		src/lava/magma/runtime/message_infrastructure/log/;
…va-nc/lava into wye_msg_ref_release2_log

	add module: log to file
        add: 2 cmake command line arguments to indicate: which levels log would be recorded, and where printed to.
                - MSG_LOG_LEVEL:
			which levels log would be recorded, valid values:
                          all: all of levels would be recorded;
                          err_warn: both error and warning would be recorded;
                          a number from 0 to 31, consists of followings:
                        	#define LOG_MASK_NULL (0)
                                #define LOG_MASK_INFO (1)
                                #define LOG_MASK_DUMP (1<<1)
                                #define LOG_MASK_DBUG (1<<2)
                                #define LOG_MASK_WARN (1<<3)
                                #define LOG_MASK_ERRO (1<<4)
			DEFAULT VALUE: 16, error log only.
		- MSG_LOG_PRINT_MODE:
			where would log be printed to, valid values:
			  all: both of console and file;
			  file: file only;
			  shell: console only;
			  null: neither
			  a number from 0 to 3, consists of followings:
				#define LOG_PRINT_MASK_NULL (0)
				#define LOG_PRINT_MASK_SHEL (1)
				#define LOG_PRINT_MASK_FILE (2)
			DEFAULT VALUE: 1, console only.
	- change: log module indicate if this log need to be printed,
		  except ERR, ERR will be printed whatever the module is.

	- fix: several blank files would be created while log_to_file
is enable but no log message to write.
	- LOG_LEVEL: from bit to number, the lowers will contain the
highers.
	- LOG_PRINT: console always, get FILE setting from compiler
macro.
@intel-whye intel-whye force-pushed the wye_msg_ref_release2_log branch 2 times, most recently from 29160c5 to 8026d29 Compare October 21, 2022 02:39
@intel-whye intel-whye force-pushed the wye_msg_ref_release2_log branch from 8026d29 to b60c220 Compare October 21, 2022 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant