forked from lava-nc/lava
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wye msg ref release2 log #9
Open
intel-whye
wants to merge
9
commits into
hongdami:messaging_refactor_release2nd
Choose a base branch
from
intel-whye:wye_msg_ref_release2_log
base: messaging_refactor_release2nd
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Wye msg ref release2 log #9
intel-whye
wants to merge
9
commits into
hongdami:messaging_refactor_release2nd
from
intel-whye:wye_msg_ref_release2_log
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code clean; add log file path option in setenv.sh, the default value is src/lava/magma/runtime/message_infrastructure/log/;
…va-nc/lava into wye_msg_ref_release2_log add module: log to file
add: 2 cmake command line arguments to indicate: which levels log would be recorded, and where printed to. - MSG_LOG_LEVEL: which levels log would be recorded, valid values: all: all of levels would be recorded; err_warn: both error and warning would be recorded; a number from 0 to 31, consists of followings: #define LOG_MASK_NULL (0) #define LOG_MASK_INFO (1) #define LOG_MASK_DUMP (1<<1) #define LOG_MASK_DBUG (1<<2) #define LOG_MASK_WARN (1<<3) #define LOG_MASK_ERRO (1<<4) DEFAULT VALUE: 16, error log only. - MSG_LOG_PRINT_MODE: where would log be printed to, valid values: all: both of console and file; file: file only; shell: console only; null: neither a number from 0 to 3, consists of followings: #define LOG_PRINT_MASK_NULL (0) #define LOG_PRINT_MASK_SHEL (1) #define LOG_PRINT_MASK_FILE (2) DEFAULT VALUE: 1, console only.
…va-nc/lava into wye_msg_ref_release2_log
- change: log module indicate if this log need to be printed, except ERR, ERR will be printed whatever the module is. - fix: several blank files would be created while log_to_file is enable but no log message to write.
…va-nc/lava into wye_msg_ref_release2_log
intel-whye
force-pushed
the
wye_msg_ref_release2_log
branch
2 times, most recently
from
October 21, 2022 02:39
29160c5
to
8026d29
Compare
intel-whye
force-pushed
the
wye_msg_ref_release2_log
branch
from
October 21, 2022 03:28
8026d29
to
b60c220
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number:
Objective of pull request:
Pull request checklist
Your PR fulfills the following requirements:
flakeheaven lint src/lava tests/
) and (bandit -r src/lava/.
) pass locallypytest
) passes locallyPull request type
Please check your PR type:
What is the current behavior?
What is the new behavior?
Does this introduce a breaking change?
Supplemental information