-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: include request id in debug logs and diagnostics #581
base: main
Are you sure you want to change the base?
Changes from 3 commits
5f7cd41
65ea57b
e2c901b
af49bec
4a6eb63
1433b23
0ddd75a
c81e65d
272be03
bd2a59e
17f6cf7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -53,8 +53,8 @@ func AddDiagnosticOnError(diag *diag.Diagnostics, summary string, err error) boo | |
} | ||
|
||
func (d DetailedErrorDiagnostic) Detail() string { | ||
response := fmt.Sprintf("ID: %s\n", d.e.ID) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We're doing some confusing things with looping over the Details of the error to generate the message, and it's otherwise not super consistent as far as I can tell. Super open to other ideas of how to format this. |
||
if len(d.e.Details) > 0 { | ||
var response string | ||
for i, dt := range d.e.Details { | ||
response += dt.Code + " - " + dt.Description | ||
|
||
|
@@ -65,7 +65,7 @@ func (d DetailedErrorDiagnostic) Detail() string { | |
return response | ||
} | ||
|
||
return d.e.Message | ||
return response + d.e.Message | ||
} | ||
|
||
func (d DetailedErrorDiagnostic) Summary() string { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed this to say "Request" because we weren't actually logging much about the response, just the request. I added the request ID and the status as well.