feat(honeycomb-opentelemetry-web): Add support for differing subdomains for debug link exporter. #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfgangcodes
changed the title
packages/honeycomb-opentelemetry-web/src/console-trace-link-exporter.ts
Outdated
Show resolved
Hide resolved
…porter.ts Co-authored-by: Mustafa Haddara <[email protected]>
martin308
approved these changes
Dec 10, 2024
| ); | ||
| } | ||
|
|
||
| export const getUrlRoots = (endpoint = '') => { | ||
| const url = new URL(endpoint); | ||
| const subdomainRegex = /(api)([.|-])?(.*?)(\.?)(honeycomb\.io)(.*)/; |
There was a problem hiding this comment.
What are we trying to capture with the (.*) group at the end, port?
There was a problem hiding this comment.
I don't think it's strictly needed, but it would match v1/traces at the end of the default endpoint value.
arriIsHere
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
This will enable this to work with EU deployments.
Short description of the changes
Infers the ui and auth URL roots from the supplied
endpoint.How to verify that this has the expected result
Pointing an example app to
https://api.eu1.honeycomb.io/v1/tracesas suggested in the sample apps should link to EU traces.