-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability for browser to receiver updates to already discovered services. #19
Conversation
Pull Request Test Coverage Report for Build 8402488019Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the addition.
EDIT: Oops, forgot some comments, see final comment below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the addition.
Just had a smaller comment and would love to request the addition of some unit test covering this functionality. Once that is implemented I'm happy to have this PR merged 🚀
@Supereg Before merging this, I think I need to increment the version in package etc. Does it auto publish to NPM or is it manual ? FYI - I have been attempting to record the publishing steps for each package here - https://github.com/homebridge/documentation/blob/latest/Repositories.md |
It will auto publish if you push a new version tag/commit. So just merge and I will publish for you. |
@Supereg Tks Merged |
Just double checked, I thought there was automatic publishing configured for this repository. It's not. It's currently manual. So feel free to create an issue for that. I'm here to help if someone wants to set something up 👍 |
I was looking at adding the ability to automatically detect changes to accessories and bridges, and needed the capability to receive TXT record updates. The existing Browser implementation just ignores them, so this pull request adds another event that will emit when a new message is received for an already discovered service.
This change is 100% backwards compatible with existing implementations.