Merge pull request #589 from mohamed-barakat/devel

ListImpliedFilters now includes the filter itself
homalg-project · Jul 12, 2023 · ad38a0e · ad38a0e
2 parents 9f042e3 + c355016
commit ad38a0e
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 6 deletions.
diff --git a/ExamplesForHomalg/PackageInfo.g b/ExamplesForHomalg/PackageInfo.g
@@ -11,7 +11,7 @@ SetPackageInfo( rec(
 
 PackageName := "ExamplesForHomalg",
 Subtitle := "Examples for the GAP Package homalg",
-Version := "2023.02-04",
+Version := "2023.07-01",
 Date := (function ( ) if IsBound( GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE ) then return GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE; else return Concatenation( ~.Version{[ 1 .. 4 ]}, "-", ~.Version{[ 6, 7 ]}, "-01" ); fi; end)( ),
 License := "GPL-2.0-or-later",
 

diff --git a/ExamplesForHomalg/examples/Oscar/ReducedBasisOfModule.g b/ExamplesForHomalg/examples/Oscar/ReducedBasisOfModule.g
@@ -1,7 +1,7 @@
-homalgIOMode("d");
-
 LoadPackage( "RingsForHomalg" );
 
+homalgIOMode("d");
+
 Qxyz := HomalgFieldOfRationalsInOscar( ) * "x,y,z";
 
 wmat := HomalgMatrix( "[ \

diff --git a/ToolsForHomalg/PackageInfo.g b/ToolsForHomalg/PackageInfo.g
@@ -10,7 +10,7 @@ SetPackageInfo( rec(
 
 PackageName := "ToolsForHomalg",
 Subtitle := "Special methods and knowledge propagation tools",
-Version := "2023.05-01",
+Version := "2023.07-01",
 Date := (function ( ) if IsBound( GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE ) then return GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE; else return Concatenation( ~.Version{[ 1 .. 4 ]}, "-", ~.Version{[ 6, 7 ]}, "-01" ); fi; end)( ),
 License := "GPL-2.0-or-later",
 

diff --git a/ToolsForHomalg/gap/ToolsForHomalg.gd b/ToolsForHomalg/gap/ToolsForHomalg.gd
@@ -527,7 +527,8 @@ DeclareGlobalFunction( "StopTimer" );
 DeclareGlobalFunction( "DisplayTimer" );
 
 #! @Description
-#!   List the all filters implied by filter <A>filt</A>.
+#!   The input is a filter <A>filt</A>.
+#!   The output is the list of all filters implied by <A>filt</A>, including <A>filt</A> itself.
 #! @Arguments filt
 DeclareGlobalFunction( "ListImpliedFilters" );
 

diff --git a/ToolsForHomalg/gap/ToolsForHomalg.gi b/ToolsForHomalg/gap/ToolsForHomalg.gi
@@ -2737,7 +2737,7 @@ InstallGlobalFunction( ListImpliedFilters,
     od;
   end;
 
-  list := [ ];
+  list := [ NamesFilter( filter )[1] ];
 
   if SIZE_FLAGS(implied) > 0 then
       Append( list, NamesFilter( reduced( TRUES_FLAGS( implied ) ) ) );