-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add u8 field type support #433
Conversation
I'm noticing, at least in the Vue framework so far, that a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one comment regarding adding the slider component as well for u8
. Not sure anyone will ever use a u8
type outside of a vector though but if it's not too much effort it would be nice I think to have the same behavior as u32
in this regard.
Yes, the components were not added, fixed now |
templates/ui-frameworks/vue/field-types/u8/Slider/edit/render.hbs
Outdated
Show resolved
Hide resolved
templates/ui-frameworks/svelte/field-types/u8/Slider/edit/render.hbs
Outdated
Show resolved
Hide resolved
Now it offers to use a Slider also when a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now 👍
* Add u8 field type * Represent Vec<u8> as a Uint8Array * Add u8 widgets * Fix misplaced lables * Fix svelte slider props * Ensure correct TS type is generated for Vec<u8> * Skip ui generation for Vec<u8> types
This PR will close #405.
Additionally, the representation of
Vec<u8>
field types in UI code is aUint8Array
instead ofArray<number>
.