feat: Enhance custom template generation #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from existing templates
c12i
changed the title
c12i
force-pushed
the
feat/add-template-new-template-subcommand
branch
from
5c7d20b to
05bbdad
Compare
|
This seems great to me! I'm not sure I'm understanding all the consequences but I think removing the nix command merely for template generation is not really a problem and being able to start a custom template from all the already available options seems really useful! |
matthme
approved these changes
Oct 30, 2024
c12i
removed
the
ShouldBackport/0.4
c12i
added a commit
that referenced
this pull request
Nov 26, 2024
* feat: Add a new template subcommand to create new custom template bases from existing templates * Remove call to wrapCustoTemplate in scaffolding nix flake * Update custom template docs
c12i
added a commit
that referenced
this pull request
Dec 10, 2024
* feat: Add a new template subcommand to create new custom template bases from existing templates * Remove call to wrapCustoTemplate in scaffolding nix flake * Update custom template docs
c12i
added a commit
that referenced
this pull request
Dec 12, 2024
* fix: Skip writing scaffold config for nixified custom templates (#415) * Add skip_config_check global flag to scaffolding * Prefer not writing the scaffold config for nixified custom templates * Fix rustfmt warning * feat: further improve ci runtime (#414) * Remove dependency to holochain * Add rust-cache * Add cachix nix config * Add ci job concurrency options * Update cachix configurations * Run rust checks/tests outside nix * add missing components * Cache rust builds * Bump holochain deps * Update rustdocs * Build cargo deps separately * refactor flake * Update maintenance docs * Add extraPullNames input to cachix actions * Add nix_build step * Extend extra-substituters and public-keys in nixConfig * Fix ci workflow * Bump client-js version * fix: Fix misplaced doc comments (#411) * Fix misplaced doc comments * Slightly refactor link_type integrity codegen * feat: Enhance custom template generation (#404) * feat: Add a new template subcommand to create new custom template bases from existing templates * Remove call to wrapCustoTemplate in scaffolding nix flake * Update custom template docs * chore: update ui dependencies (#407) * Bump holochain playground * Update ui core dependencies * Update lit dependencies * Fix cli output lines * Fix broken css import in lit template * Revert custom-template changes * Fix vue templates * Increase testTimeout * Remove eslint from lit template * Fix lit CI failure * Add missing shared styles * feat: Reprompt user on invalid input (#402) * Fix imports * Merge pull request #428 from holochain/fix/svelte-client-race-condition-0.4 chore: backport svelte race condition to 0.4 and release 0.4000.0-rc.1 * feat: Add ability to go back and modify entry type fields (#418) * Add go back functionality for hc scaffold entry-type * address PR comments * Ensure the fields vec is not empty on change * Improve text spacing * Simplify prompt * Pin typescript version for vue-tsc compatibility --------- Co-authored-by: matthme <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the separate
custom-templatewith a system that builds custom templates from existing template bases (vue, svelte, lit, react, headless).Changes
custom-templatenix flake initto CLI-based template generationBenefits
Trade-offs
nix flake init -t github:holochain/scaffoldingworkflownix run github:holochain/scaffolding#hc-scaffold -- template neworhc-scaffold template newif installed via cargoRationale
The increased flexibility and reduced maintenance overhead outweigh the loss of the nix flake init workflow, as developers gain access to multiple template starting points instead of being limited to the previous lit-based custom template.
TODOs
Closes #388