Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken package.json for holo #140

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

pdaoust
Copy link
Collaborator

@pdaoust pdaoust commented Nov 2, 2023

When trying to scaffold a Holo-enabled hApp, npm complained that the package.json wasn't actual JSON. Looks like it's all about a trailing comma. This should fix it.

@ThetaSinner ThetaSinner force-pushed the fix-broken-package-json-for-holo branch from 44bbc6c to 4d2656d Compare November 3, 2023 14:42
@ThetaSinner ThetaSinner enabled auto-merge November 3, 2023 14:43
@ThetaSinner ThetaSinner merged commit 5709f58 into develop Nov 3, 2023
1 check passed
@ThetaSinner ThetaSinner deleted the fix-broken-package-json-for-holo branch November 3, 2023 15:35
@ThetaSinner ThetaSinner added ShouldBackport/0.1 This change should be backported to develop-0.1 ShouldBackport/0.2 This change should be backported to develop-0.2 labels Nov 3, 2023
ThetaSinner added a commit that referenced this pull request Nov 28, 2023
ThetaSinner added a commit that referenced this pull request Nov 28, 2023
@ThetaSinner ThetaSinner removed ShouldBackport/0.2 This change should be backported to develop-0.2 ShouldBackport/0.1 This change should be backported to develop-0.1 labels Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants