Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links, paths, and anchors #453

Open
wants to merge 38 commits into
base: main
Choose a base branch
from
Open

Links, paths, and anchors #453

wants to merge 38 commits into from

Conversation

pdaoust
Copy link
Collaborator

@pdaoust pdaoust commented Jun 6, 2024

Resolves #467

Seeking review for:

  • Succinctness of prose -- do you get lost? Is there too much information, is the complex stuff (e.g., introducing how to get a hash for linking) introduced too early?
  • Correctness of code at first glance -- I have to confess I haven't tried compiling any of it yet.

@pdaoust pdaoust requested review from mattyg, mjbrisebois and c12i June 6, 2024 22:07
Copy link

@mjbrisebois mjbrisebois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I didn't know how to use the anchor functions until reading this.

src/pages/build/links-paths-and-anchors.md Outdated Show resolved Hide resolved
src/pages/build/links-paths-and-anchors.md Outdated Show resolved Hide resolved
Copy link
Member

@mattyg mattyg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome stuff thanks for taking this on!

src/pages/build/entries.md Outdated Show resolved Hide resolved
Copy link
Member

@mattyg mattyg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thrilled with this, amazing work

@pdaoust
Copy link
Collaborator Author

pdaoust commented Dec 20, 2024

@mattyg thanks so much for all the encouragement -- glad to hear it's landing 🙏🏼 I've been out of programming for so long that positive feedback is very welcome. And I think I'm getting the hang of writing Rust code (and hApp code), although there are some gnarly things along the way (e.g., holochain/holochain#4575 ).

I've tried compiling all the code samples and discovered that there were a fair few errors; would you be willing to re-review this PR and make sure my 'solutions' to the errors are all reasonably idiomatic?

src/pages/build/entries.md Outdated Show resolved Hide resolved
src/pages/build/entries.md Outdated Show resolved Hide resolved
Copy link
Member

@mattyg mattyg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple issues in comments, otherwise looks good.

Copy link
Member

@mattyg mattyg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Practical docs for using Links
4 participants