-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Links, paths, and anchors #453
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. I didn't know how to use the anchor functions until reading this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome stuff thanks for taking this on!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thrilled with this, amazing work
Co-authored-by: mattyg <[email protected]>
@mattyg thanks so much for all the encouragement -- glad to hear it's landing 🙏🏼 I've been out of programming for so long that positive feedback is very welcome. And I think I'm getting the hang of writing Rust code (and hApp code), although there are some gnarly things along the way (e.g., holochain/holochain#4575 ). I've tried compiling all the code samples and discovered that there were a fair few errors; would you be willing to re-review this PR and make sure my 'solutions' to the errors are all reasonably idiomatic? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple issues in comments, otherwise looks good.
Most of mattyg's suggestions; just missing a couple that I couldn't edit directly. Co-authored-by: mattyg <[email protected]>
…to feat/guide/links
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 🔥
Resolves #467
Seeking review for: