Fix issue 49 #50
Merged
Fix issue 49 #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holochain-gym#49 Note: This is strictly to bring the file into line with the docs (also see holochain-gym/holochain-gym.github.io#50). The functionality has not been tested.
This was referenced Dec 3, 2021
guillemcordoba
approved these changes
Dec 6, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#49
Note: This is strictly to bring the file into line with the docs (also see holochain-gym/holochain-gym.github.io#50). The functionality has not been tested.
Edit:
Based on the solution code, it looks like the code in the docs is a bit of a red herring. E.g., we don't use a
someExternalInputstruct. So it may be the docs that need updating. However, if that's the case, I think the explanation of the exercise needs to change a bit to suit. Feel free to close this PR in that case.