chore: delete no longer relevant todo comments, commented out code #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattyg
commented
Oct 27, 2024
| @@ -357,7 +356,6 @@ export class ConversationStore { | |||
| const id = uuidv4() | |||
| const oldMessage: Message = { authorKey, content, hash: id, status: 'pending', timestamp: now, bucket, images} | |||
| this.addMessage(oldMessage) | |||
| // TODO: upload these images asynchonously and then add to the message when done | |||
There was a problem hiding this comment.
This is already implemented, unless I misunderstood.
mattyg
commented
Oct 27, 2024
| @@ -187,7 +187,6 @@ export class RelayStore { | |||
|
|
|||
| async createContact(contact: Contact) { | |||
| if (!this.client) return false | |||
| // TODO: if adding contact fails we should remove it from the store | |||
There was a problem hiding this comment.
Contact is only added to the store once successful;
mattyg
commented
Oct 27, 2024
| @@ -220,7 +220,6 @@ export class ConversationStore { | |||
| } | |||
|
|
|||
| get title() { | |||
| // TODO: when invited contacts is stored in HC this can go back to invitedContactKeys | |||
There was a problem hiding this comment.
This I don't understand at all.
mattyg
commented
Oct 27, 2024
| @@ -137,7 +137,7 @@ export class ConversationStore { | |||
| } | |||
|
|
|||
| const invitation: Invitation = { | |||
| created: this.created, // TODO: put in data | |||
There was a problem hiding this comment.
It already is in the invitation data? Or am I missing something?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #186