New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ui): extract lightbox logic to its own component #163

Merged

mattyg merged 1 commit into main from fix/display-close-on-lightbox

Oct 21, 2024

Collaborator

mattyg commented Oct 17, 2024 •

edited

Loading

extract lightbox into its own component
keep lightbox close button visible on small viewports while zooming

todo

should only have to tap close button once -- even while zoomed on small viewports (moved to Should be able to close image lightbox while zoomed by tapping close button once #166)


          refactor(ui): extract lightbox logic to its own component, show close…

9b23254

… button on small viewports when zooming

mattyg marked this pull request as ready for review

October 21, 2024 18:24

mattyg merged commit 924dcd0 into main

mattyg deleted the fix/display-close-on-lightbox branch

October 21, 2024 18:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet