Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code organization, cleanup, linting, packages updates #3

Merged
merged 11 commits into from
Aug 13, 2024

Conversation

Zequez
Copy link
Collaborator

@Zequez Zequez commented Aug 13, 2024

  • Added a shared folder for stuff used on both Home and GamezPane screens; and accompanying import alias
  • Moved files on either Home and GamezPane folders accordingly
  • Fixed all TypeScript errors, UI check script runs clean
  • Added prettier and improved prettier configuration; added a dependency sorting plugin but it turns out it doesn't support .svelte files yet. However it might soon, and on the prettier configuration it documents how the imports are meant to be sorted: "third-party", "holochain/LrL", "shared", "relative"
  • Updated svelte-check to latest version, which resolved a bunch of issues
  • Process all UI files through prettier
  • Updated CI to work with latest Nix version, and to run TypeScript checks using svelte-check on the UI workspace
  • Update to Svelte 4, Typescript 5, Vite 5; and all other deps on /ui
  • Use same loader component everywhere
  • Removed many unused files

@Zequez Zequez changed the title Code organization, linting, packages updates Code organization, cleanup, linting, packages updates Aug 13, 2024
@Zequez Zequez marked this pull request as ready for review August 13, 2024 02:20
@Zequez Zequez merged commit 118d1b2 into main Aug 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant