This repository has been archived by the owner on Feb 24, 2024. It is now read-only.
Add async packet sending #88
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MelonHell
force-pushed
the
patch/async-packet-sending
branch
from
cc87751 to
6963ca7
Compare
|
With java 21 we will need to start removing uses of synchronized in most places (it doesn't play well with virtual threads). I do not want to introduce more use cases (it should use a ReentrantLock instead most likely). I think "async" is somewhat misleading here. It can be used async, but really it is writing immediately (and synchronously) in the current thread. I would prefer some name like Finally, while I am ok with this change in theory, I am very unclear on the performance detriment of locking on all writes. |
MelonHell
force-pushed
the
patch/async-packet-sending
branch
3 times, most recently
from
1cb15a6 to
f40dd71
Compare
MelonHell
force-pushed
the
patch/async-packet-sending
branch
2 times, most recently
from
9b4fe49 to
a5b5530
Compare
MelonHell
force-pushed
the
patch/async-packet-sending
branch
from
a5b5530 to
f117182
Compare
# Conflicts: # src/main/java/net/minestom/server/network/player/PlayerSocketConnection.java
# Conflicts: # src/main/java/net/minestom/server/network/player/PlayerSocketConnection.java
MelonHell
force-pushed
the
patch/async-packet-sending
branch
from
f117182 to
40e3f6d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #79
prev pr #82 (I needed to rename the branch)
Not ready yet, sometimes client throws this exception
