Localize not implemented warning

holgerstolzenberg · Mar 6, 2024 · 7916f48 · 7916f48
1 parent efb5ff4
commit 7916f48
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 6 deletions.
diff --git a/src/app/i18n/i18n.service.ts b/src/app/i18n/i18n.service.ts
@@ -13,6 +13,10 @@ export class I18nService {
     return this.translocoService.selectTranslate<string>(key);
   }
 
+  translateMultiple(keys: string[]) {
+    return this.translocoService.selectTranslateObject(keys);
+  }
+
   setActiveLang(languageCode: string) {
     this.translocoService.setActiveLang(languageCode);
   }

diff --git a/src/app/map/map.component.ts b/src/app/map/map.component.ts
@@ -73,12 +73,12 @@ export class MapComponent implements OnInit, AfterViewInit, OnDestroy {
 
     // TODO deck.gl: this.resetMap();
     this.mapService.resetMap$.pipe(takeUntil(this.onUnsubscribe$)).subscribe(() => {
-      this.notificationService.showWarn('Not implemented yet');
+      this.notificationService.showWarnLocalized('common.not-implemented');
     });
 
     // TODO deck.gl: this.myLocation();
     this.mapService.toMyLocation$.pipe(takeUntil(this.onUnsubscribe$)).subscribe(() => {
-      this.notificationService.showWarn('Not implemented yet');
+      this.notificationService.showWarnLocalized('common.not-implemented');
     });
 
     this.mapService.showEuBorders$.pipe(takeUntil(this.onUnsubscribe$)).subscribe(value => {

diff --git a/src/app/notifications/notification.service.ts b/src/app/notifications/notification.service.ts
@@ -27,10 +27,11 @@ export class NotificationService {
     );
   }
 
-  showWarn(message: string) {
-    this.log.warn(message);
-    firstValueFrom(this.i18nService.translate('notifications.warn-title')).then(title =>
-      this.toastrService.warning(message, title, options)
+  showWarnLocalized(messageKey: string) {
+    this.log.warn(messageKey);
+
+    firstValueFrom(this.i18nService.translateMultiple(['notifications.warn-title', messageKey])).then(values =>
+      this.toastrService.warning(values[1], values[0], options)
     );
   }
 }
diff --git a/src/assets/i18n/de.json b/src/assets/i18n/de.json
@@ -1,4 +1,7 @@
 {
+  "common": {
+    "not-implemented": "Feature nicht implementiert"
+  },
   "header": {
     "title": "Europas Städte"
   },

diff --git a/src/assets/i18n/en.json b/src/assets/i18n/en.json
@@ -1,4 +1,7 @@
 {
+  "common": {
+    "not-implemented": "Feature not implemented"
+  },
   "header": {
     "title": "Cities of Europe"
   },