Skip to content

Commit

Permalink
Merge pull request #10 from holgerstolzenberg/feature/deck-gl-migration
Browse files Browse the repository at this point in the history
Feature/deck gl migration
  • Loading branch information
holgerstolzenberg authored Mar 9, 2024
2 parents aca379a + 23ebd95 commit 1544cbc
Show file tree
Hide file tree
Showing 38 changed files with 1,514 additions and 432 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/feature-branch-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
- name: Lint
run: npm run lint

# TODO find a way to configure URL at runtime
# TODO ci: find a way to configure URL at runtime
- name: Build
run: |
npm run build -- --configuration=production --base-href=/cities-of-europe/
2 changes: 1 addition & 1 deletion .github/workflows/main-branch-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
- name: Lint
run: npm run lint

# TODO find a way to configure URL at runtime
# TODO ci: find a way to configure URL at runtime
- name: Build
run: |
npm run build -- --configuration=production --base-href=/cities-of-europe/
Expand Down
12 changes: 7 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

## 🚀 Introduction

This is just a small sample project to get up to date with Angular and learn some Leaflet stuff.
This is just a small sample project to get up to date with Angular and learn some [deck.gl](https://deck.gl) stuff.

## 🫡 Commands

Expand Down Expand Up @@ -32,18 +32,20 @@ docker run [-it] -p8080:8080 -p2019:2019 holgerstolzenberg/cities-of-europe
- ☑️Add user interactions for layer control
- ☑️Expandable toolbar
- ☑️Own location finder
- Discover Leaflet plugins
- Weather overlays
- Smoother map animation (only mac chrome so far, retina)
- ☑️Smoother map animation (only mac chrome so far, retina)
- ☑️Add loading indicator
- ☑️Slider for map pitch angle
- Cross-hair on own location
- Map initializing indicator
- Weather or other overlays, distance to cities

## Development

- Investigate 404 on app start
- Better SCSS structure and cleanup
- Cleanup of .whatever configurations (Prettier, ESLint, etc.)
- ☑️Pin package.json versions
- Glitching focus frame around map
- ☑️Glitching focus frame around map

## Packaging

Expand Down
12 changes: 3 additions & 9 deletions angular.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,15 +51,9 @@
"inlineStyleLanguage": "scss",
"assets": [
"src/favicon.ico",
"src/assets",
{
"glob": "**/*",
"input": "node_modules/leaflet/dist/images/",
"output": "./assets/leaflet"
}
"src/assets"
],
"styles": [
"node_modules/leaflet/dist/leaflet.css",
"node_modules/ngx-toastr/toastr.css",
"src/assets/styles/main.scss"
],
Expand All @@ -75,8 +69,8 @@
"budgets": [
{
"type": "initial",
"maximumWarning": "500kb",
"maximumError": "1mb"
"maximumWarning": "1500kb",
"maximumError": "2mb"
},
{
"type": "anyComponentStyle",
Expand Down
Loading

0 comments on commit 1544cbc

Please sign in to comment.