cmd/feedback: remove flag shorthands that are conflicting with global…

… flags (#399) Co-authored-by: Tony Worm <[email protected]>
hofstadter-io · Dec 15, 2024 · 1f0e59b · 1f0e59b
1 parent 3d37c83
commit 1f0e59b
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/.hof/shadow/cli/cmd/hof/flags/feedback.go b/.hof/shadow/cli/cmd/hof/flags/feedback.go
@@ -16,8 +16,8 @@ type FeedbackPflagpole struct {
 func SetupFeedbackPflags(fset *pflag.FlagSet, fpole *FeedbackPflagpole) {
 	// pflags
 
-	fset.BoolVarP(&(fpole.Issue), "issue", "I", false, "create an issue (discussion is default)")
-	fset.StringVarP(&(fpole.Labels), "labels", "L", "feedback", "labels,comma,separated")
+	fset.BoolVarP(&(fpole.Issue), "issue", "", false, "create an issue (discussion is default)")
+	fset.StringVarP(&(fpole.Labels), "labels", "", "feedback", "labels,comma,separated")
 }
 
 var FeedbackPflags FeedbackPflagpole

diff --git a/cmd/hof/flags/feedback.go b/cmd/hof/flags/feedback.go
@@ -16,8 +16,8 @@ type FeedbackPflagpole struct {
 func SetupFeedbackPflags(fset *pflag.FlagSet, fpole *FeedbackPflagpole) {
 	// pflags
 
-	fset.BoolVarP(&(fpole.Issue), "issue", "I", false, "create an issue (discussion is default)")
-	fset.StringVarP(&(fpole.Labels), "labels", "L", "feedback", "labels,comma,separated")
+	fset.BoolVarP(&(fpole.Issue), "issue", "", false, "create an issue (discussion is default)")
+	fset.StringVarP(&(fpole.Labels), "labels", "", "feedback", "labels,comma,separated")
 }
 
 var FeedbackPflags FeedbackPflagpole

diff --git a/design/cmds/feedback.cue b/design/cmds/feedback.cue
@@ -17,14 +17,14 @@ FeedbackCommand: schema.Command & {
 	Pflags: [{
 		Name:    "issue"
 		Long:    "issue"
-		Short:   "I"
+		Short:   ""
 		Type:    "bool"
 		Default: "false"
 		Help:    "create an issue (discussion is default)"
 	}, {
 		Name:    "labels"
 		Long:    "labels"
-		Short:   "L"
+		Short:   ""
 		Type:    "string"
 		Default: "\"feedback\""
 		Help:    "labels,comma,separated"