Fix coverity warning

hoene · Jan 24, 2021 · 8dda834 · 8dda834
1 parent 4c1806c
commit 8dda834
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/hdf/dataobject.c b/src/hdf/dataobject.c
@@ -67,11 +67,11 @@ static int readOHDRHeaderMessageDataspace1(struct READER *reader,
     if (i < 4) {
       ds->dimension_size[i] =
           readValue(reader, reader->superblock.size_of_lengths);
-      mylog("   dimension %d %" PRIu64 "\n", i, ds->dimension_size[i]);
-      if (ds->dimension_size[i] > 1000000) {
+      if (ds->dimension_size[i] < 0 || ds->dimension_size[i] > 1000000) {
         mylog("dimension_size is too large\n"); // LCOV_EXCL_LINE
         return MYSOFA_INVALID_FORMAT;           // LCOV_EXCL_LINE
       }
+      mylog("   dimension %d %" PRIu64 "\n", i, ds->dimension_size[i]);
     } else
       readValue(reader, reader->superblock.size_of_lengths);
   }