Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DL-15127 : remove the view submitted vat return detail #332

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kannanEkambaram
Copy link
Contributor

No description provided.

@platops-pr-bot
Copy link

  • Scala can be updated from 2.12.12 to 2.13.8 in build.sbt - See confluence https://confluence.tools.tax.service.gov.uk/x/L4HJHw
  • uk.gov.hmrc.sbt-auto-build can be updated to 3.24.0 in project/plugins.sbt
  • Runtime issues may occur. Change com.typesafe.play.sbt-plugin to 2.8.20 in project/plugins.sbt - to match what uk.gov.hmrc.play-frontend-hmrc-play-28 uses
  • Config key auditing.traceRequests can be removed from conf/application.conf. It has been unused since play-auditing:3.0.0
  • SBT setting .settings(publishingSettings: _*) in build.sbt can be removed, the import can also be removed. It is not required from sbt-distributables:2.2.0 onwards
  • SbtAutoBuildPlugin can be removed from build.sbt - it's been automatically enabled since 3.0.0
  • SbtGitVersioning can be removed from build.sbt - it's been automatically enabled since 1.7.0
  • STDOUT_IGNORE_NETTY appender (and usage) can be removed from conf/logback.xml - Netty server is no longer used (Since Play 2.6.x)
  • ACCESS_LOG_FILE appender (and usage) can be removed from conf/logback.xml - it's never populated
  • Add uk.gov.hmrc.bootstrap-test-play-28 in project/AppDependencies.scala to provide recommended test dependencies. Use a variable to keep version in sync with bootstrap-play
  • There is a bobby error - see the pr builder for details

@kannanEkambaram kannanEkambaram force-pushed the DL-15127 branch 2 times, most recently from abeccab to d2706d2 Compare December 24, 2024 10:41
@platops-pr-bot
Copy link

  • Scala can be updated from 2.12.12 to 2.13.8 in build.sbt - See confluence https://confluence.tools.tax.service.gov.uk/x/L4HJHw
  • Runtime issues may occur. Change com.typesafe.play.sbt-plugin to 2.8.20 in project/plugins.sbt - to match what uk.gov.hmrc.play-frontend-hmrc-play-28 uses
  • SBT setting .settings(publishingSettings: _*) in build.sbt can be removed, the import can also be removed. It is not required from sbt-distributables:2.2.0 onwards
  • Add uk.gov.hmrc.bootstrap-test-play-28 in project/AppDependencies.scala to provide recommended test dependencies. Use a variable to keep version in sync with bootstrap-play
  • There is a bobby error - see the pr builder for details
  • Your service can now use Java 21. Please set JavaType.OPENJDK_JRE21 in build-jobs - See confluence https://confluence.tools.tax.service.gov.uk/x/xIACM
  • uk.gov.hmrc.sbt-auto-build can be updated to 3.24.0 in project/plugins.sbt
  • Runtime issues may occur. Change org.playframework.sbt-plugin to 3.0.3 in project/plugins.sbt - to match what uk.gov.hmrc.bootstrap-frontend-play-30 uses
  • Config key auditing.traceRequests can be removed from conf/application.conf. It has been unused since play-auditing:3.0.0
  • SbtAutoBuildPlugin can be removed from build.sbt - it's been automatically enabled since 3.0.0
  • SbtGitVersioning can be removed from build.sbt - it's been automatically enabled since 1.7.0
  • STDOUT_IGNORE_NETTY appender (and usage) can be removed from conf/logback.xml - Netty server is no longer used (Since Play 2.6.x)
  • ACCESS_LOG_FILE appender (and usage) can be removed from conf/logback.xml - it's never populated
  • File conf/application-json-logger.xml can be removed. Logging is provided by Bootstrap (since 8.6.0) and can be configured via application config alone - See confluence https://confluence.tools.tax.service.gov.uk/x/9oH1FQ
  • Config key play.application.loader can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key play.http.requestHandler can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key metrics.name can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key metrics.rateUnit can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key metrics.durationUnit can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key metrics.showSamples can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key metrics.jvm can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key metrics.enabled can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key microservice.metrics.graphite.prefix can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key microservice.metrics.graphite.host can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key microservice.metrics.graphite.port can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key microservice.metrics.graphite.enabled can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key auditing.enabled can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key auditing.consumer.baseUri.host can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key auditing.consumer.baseUri.port can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config module uk.gov.hmrc.play.audit.AuditModule can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config module uk.gov.hmrc.play.bootstrap.graphite.GraphiteMetricsModule can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config module uk.gov.hmrc.play.bootstrap.frontend.FrontendModule can be removed from conf/application.conf. This is already provided by Bootstrap
  • Add uk.gov.hmrc.bootstrap-test-play-30 in project/AppDependencies.scala to provide recommended test dependencies. Use a variable to keep version in sync with bootstrap-play

@kannanEkambaram kannanEkambaram force-pushed the DL-15127 branch 3 times, most recently from b51f680 to 5aa4192 Compare December 24, 2024 13:49
@platops-pr-bot
Copy link

  • Scala can be updated from 2.12.12 to 2.13.8 in build.sbt - See confluence https://confluence.tools.tax.service.gov.uk/x/L4HJHw
  • Runtime issues may occur. Change com.typesafe.play.sbt-plugin to 2.8.20 in project/plugins.sbt - to match what uk.gov.hmrc.play-frontend-hmrc-play-28 uses
  • SBT setting .settings(publishingSettings: _*) in build.sbt can be removed, the import can also be removed. It is not required from sbt-distributables:2.2.0 onwards
  • Add uk.gov.hmrc.bootstrap-test-play-28 in project/AppDependencies.scala to provide recommended test dependencies. Use a variable to keep version in sync with bootstrap-play
  • There is a bobby error - see the pr builder for details
  • uk.gov.hmrc.sbt-auto-build can be updated to 3.24.0 in project/plugins.sbt
  • Runtime issues may occur. Change org.playframework.sbt-plugin to 3.0.3 in project/plugins.sbt - to match what uk.gov.hmrc.bootstrap-frontend-play-30 uses
  • Config key auditing.traceRequests can be removed from conf/application.conf. It has been unused since play-auditing:3.0.0
  • SbtAutoBuildPlugin can be removed from build.sbt - it's been automatically enabled since 3.0.0
  • SbtGitVersioning can be removed from build.sbt - it's been automatically enabled since 1.7.0
  • STDOUT_IGNORE_NETTY appender (and usage) can be removed from conf/logback.xml - Netty server is no longer used (Since Play 2.6.x)
  • ACCESS_LOG_FILE appender (and usage) can be removed from conf/logback.xml - it's never populated
  • Config key play.application.loader can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key play.http.requestHandler can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key metrics.name can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key metrics.rateUnit can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key metrics.durationUnit can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key metrics.showSamples can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key metrics.jvm can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key metrics.enabled can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key auditing.enabled can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key auditing.consumer.baseUri.host can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key auditing.consumer.baseUri.port can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config module uk.gov.hmrc.play.audit.AuditModule can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config module uk.gov.hmrc.play.bootstrap.graphite.GraphiteMetricsModule can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config module uk.gov.hmrc.play.bootstrap.frontend.FrontendModule can be removed from conf/application.conf. This is already provided by Bootstrap
  • Your service can now use Java 21. Please set JavaType.OPENJDK_JRE21 in build-jobs - See confluence https://confluence.tools.tax.service.gov.uk/x/xIACM
  • File conf/application-json-logger.xml can be removed. Logging is provided by Bootstrap (since 8.6.0) and can be configured via application config alone - See confluence https://confluence.tools.tax.service.gov.uk/x/9oH1FQ
  • Config key microservice.metrics.graphite.prefix can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key microservice.metrics.graphite.host can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key microservice.metrics.graphite.port can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key microservice.metrics.graphite.enabled can be removed from conf/application.conf. This is already provided by Bootstrap
  • Add uk.gov.hmrc.bootstrap-test-play-30 in project/AppDependencies.scala to provide recommended test dependencies. Use a variable to keep version in sync with bootstrap-play

@platops-pr-bot
Copy link

  • Scala can be updated from 2.12.12 to 2.13.8 in build.sbt - See confluence https://confluence.tools.tax.service.gov.uk/x/L4HJHw
  • Runtime issues may occur. Change com.typesafe.play.sbt-plugin to 2.8.20 in project/plugins.sbt - to match what uk.gov.hmrc.play-frontend-hmrc-play-28 uses
  • SBT setting .settings(publishingSettings: _*) in build.sbt can be removed, the import can also be removed. It is not required from sbt-distributables:2.2.0 onwards
  • Add uk.gov.hmrc.bootstrap-test-play-28 in project/AppDependencies.scala to provide recommended test dependencies. Use a variable to keep version in sync with bootstrap-play
  • There is a bobby error - see the pr builder for details
  • uk.gov.hmrc.sbt-auto-build can be updated to 3.24.0 in project/plugins.sbt
  • Runtime issues may occur. Change org.playframework.sbt-plugin to 3.0.3 in project/plugins.sbt - to match what uk.gov.hmrc.bootstrap-frontend-play-30 uses
  • Config key auditing.traceRequests can be removed from conf/application.conf. It has been unused since play-auditing:3.0.0
  • SbtAutoBuildPlugin can be removed from build.sbt - it's been automatically enabled since 3.0.0
  • SbtGitVersioning can be removed from build.sbt - it's been automatically enabled since 1.7.0
  • STDOUT_IGNORE_NETTY appender (and usage) can be removed from conf/logback.xml - Netty server is no longer used (Since Play 2.6.x)
  • ACCESS_LOG_FILE appender (and usage) can be removed from conf/logback.xml - it's never populated
  • Config key play.application.loader can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key play.http.requestHandler can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key metrics.name can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key metrics.rateUnit can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key metrics.durationUnit can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key metrics.showSamples can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key metrics.jvm can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key metrics.enabled can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key auditing.enabled can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key auditing.consumer.baseUri.host can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key auditing.consumer.baseUri.port can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config module uk.gov.hmrc.play.audit.AuditModule can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config module uk.gov.hmrc.play.bootstrap.graphite.GraphiteMetricsModule can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config module uk.gov.hmrc.play.bootstrap.frontend.FrontendModule can be removed from conf/application.conf. This is already provided by Bootstrap
  • Your service can now use Java 21. Please set JavaType.OPENJDK_JRE21 in build-jobs - See confluence https://confluence.tools.tax.service.gov.uk/x/xIACM
  • File conf/application-json-logger.xml can be removed. Logging is provided by Bootstrap (since 8.6.0) and can be configured via application config alone - See confluence https://confluence.tools.tax.service.gov.uk/x/9oH1FQ
  • Config key microservice.metrics.graphite.prefix can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key microservice.metrics.graphite.host can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key microservice.metrics.graphite.port can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key microservice.metrics.graphite.enabled can be removed from conf/application.conf. This is already provided by Bootstrap
  • Add uk.gov.hmrc.bootstrap-test-play-30 in project/AppDependencies.scala to provide recommended test dependencies. Use a variable to keep version in sync with bootstrap-play

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants