DDCE-4700 Fix summaryListId accessability issue (#512)

hmrc · Nov 7, 2023 · 8ecc3f6 · 8ecc3f6
1 parent 94b11e1
commit 8ecc3f6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/app/uk/gov/hmrc/merchandiseinbaggage/viewmodels/GoodsSummaryList.scala b/app/uk/gov/hmrc/merchandiseinbaggage/viewmodels/GoodsSummaryList.scala
@@ -97,7 +97,7 @@ object GoodsSummaryList {
         )
       ),
       classes = "govuk-!-margin-bottom-1",
-      attributes = Map("id" -> s"summaryListId$idx")
+      attributes = Map("id" -> s"summaryListId_$idx")
     )
 
   private def exportSummary(goods: ExportGoods, idx: Int)(implicit messages: Messages): SummaryList =

diff --git a/test/uk/gov/hmrc/merchandiseinbaggage/content/ReviewGoodsContentSpec.scala b/test/uk/gov/hmrc/merchandiseinbaggage/content/ReviewGoodsContentSpec.scala
@@ -62,7 +62,7 @@ class ReviewGoodsContentSpec extends ReviewGoodsPage with CoreTestData with Prop
   }
 
   private def rowTest(rowNumber: Int, key: String, value: String, changeLink: String): Assertion = {
-    val row                              = findById("summaryListId1").findElements(By.className("govuk-summary-list__row")).get(rowNumber)
+    val row                              = findById("summaryListId_1").findElements(By.className("govuk-summary-list__row")).get(rowNumber)
     val rowElement: String => WebElement = className => row.findElement(By.className(className))
 
     rowElement("govuk-summary-list__key").getText mustBe messages(key)