Skip to content

Commit

Permalink
Merge pull request #544 from hmrc/DDCE-6203
Browse files Browse the repository at this point in the history
DDCE-6203 - Remove sbt-accessibility-linter
  • Loading branch information
SachaMcCormack authored Nov 14, 2024
2 parents cda411a + 23e9cda commit 691c8bf
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 152 deletions.
13 changes: 1 addition & 12 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ The stride roles for the admin mode are `tps_payment_taker_call_handler,digital_

## Running Tests

To run unit tests, integration tests, a11y tests, scalafmt, coverage and check dependencies, execute the script:
To run unit tests, integration tests, scalafmt, coverage and check dependencies, execute the script:

```bash
./run_all_tests.sh
Expand Down Expand Up @@ -69,17 +69,6 @@ sm2 --start MERCHANDISE_IN_BAGGAGE_ALL --appendArgs '{"PAYMENTS_PROCESSOR":["-Dm

* Run the UI tests which can be found [here](https://github.com/hmrc/merchandise-in-baggage-ui-tests).

### Running Accessibility Tests

#### Prerequisites
Have node installed on your machine.

#### Execute tests
To run the tests locally, simply run:
```bash
sbt clean A11y/test
```

## Enabling 'Admin Mode'

This service is built to accept traffic from the `admin.tax.service.gov.uk` domain as well for assisted digital journeys.
Expand Down
129 changes: 0 additions & 129 deletions a11y/FrontendAccessibilitySpec.scala

This file was deleted.

2 changes: 1 addition & 1 deletion build.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,4 @@ lazy val it = project
.dependsOn(microservice % "test->test") // the "test->test" allows reusing test code and test dependencies
.settings(itSettings())

addCommandAlias("scalafmtAll", "all scalafmtSbt scalafmt Test/scalafmt A11y/scalafmt it/Test/scalafmt")
addCommandAlias("scalafmtAll", "all scalafmtSbt scalafmt Test/scalafmt it/Test/scalafmt")
2 changes: 1 addition & 1 deletion project/AppDependencies.scala
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ object AppDependencies {

private val compile: Seq[ModuleID] = Seq(
"uk.gov.hmrc" %% "bootstrap-frontend-play-30" % bootstrapVersion,
"uk.gov.hmrc" %% "play-frontend-hmrc-play-30" % "11.3.0",
"uk.gov.hmrc" %% "play-frontend-hmrc-play-30" % "11.5.0",
"uk.gov.hmrc.mongo" %% "hmrc-mongo-play-30" % "2.3.0",
"com.beachape" %% "enumeratum-play" % "1.8.2",
"org.webjars.npm" % "accessible-autocomplete" % "3.0.0",
Expand Down
15 changes: 7 additions & 8 deletions project/plugins.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,10 @@ resolvers += Resolver.url("HMRC-open-artefacts-ivy2", url("https://open.artefact
Resolver.ivyStylePatterns
)

addSbtPlugin("uk.gov.hmrc" % "sbt-auto-build" % "3.22.0")
addSbtPlugin("uk.gov.hmrc" % "sbt-distributables" % "2.5.0")
addSbtPlugin("org.playframework" % "sbt-plugin" % "3.0.5")
addSbtPlugin("io.github.irundaia" % "sbt-sassify" % "1.5.2")
addSbtPlugin("org.scalameta" % "sbt-scalafmt" % "2.5.2")
addSbtPlugin("org.scoverage" % "sbt-scoverage" % "2.2.1")
addSbtPlugin("com.timushev.sbt" % "sbt-updates" % "0.6.4")
addSbtPlugin("uk.gov.hmrc" % "sbt-accessibility-linter" % "1.0.0")
addSbtPlugin("uk.gov.hmrc" % "sbt-auto-build" % "3.22.0")
addSbtPlugin("uk.gov.hmrc" % "sbt-distributables" % "2.5.0")
addSbtPlugin("org.playframework" % "sbt-plugin" % "3.0.5")
addSbtPlugin("io.github.irundaia" % "sbt-sassify" % "1.5.2")
addSbtPlugin("org.scalameta" % "sbt-scalafmt" % "2.5.2")
addSbtPlugin("org.scoverage" % "sbt-scoverage" % "2.2.1")
addSbtPlugin("com.timushev.sbt" % "sbt-updates" % "0.6.4")
2 changes: 1 addition & 1 deletion run_all_tests.sh
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
#!/usr/bin/env bash

sbt clean compile scalafmtAll coverage test it/test coverageOff coverageReport A11y/test dependencyUpdates
sbt clean compile scalafmtAll coverage test it/test coverageOff coverageReport dependencyUpdates

0 comments on commit 691c8bf

Please sign in to comment.