Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to handle non auth related errors #103

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix to handle non auth related errors #103

wants to merge 2 commits into from

Conversation

basotia
Copy link

@basotia basotia commented Dec 24, 2024

Description

Please include a brief summary of the change you've made and the issue that it fixes.

Add a link to the relevant story in Jira
[SASS-CHANGE-ME](ADD URL HERE)

Checklist PR Reviewer

Before Reviewing
  • Have you pulled the branch down?
  • Have you assigned yourself to the PR?
  • Have you moved the task to “in review” on JIRA?
  • Have you checked to ensure all dependencies are up to date?
  • Have you checked to ensure its been rebased against the current version of main?
Whilst Reviewing
  • Have you run the tests?
  • Have you run the journey tests?
  • Have you looked at the JIRA story to make sure all Acceptance Criteria has been met?
After Reviewing
  • Have you checked for merge conflicts or any changes in the current main that may affect the current pull request?
    i.e. does it need another rebase?
  • Have you checked to make sure there are no builds in the pipeline before you merge?
  • Have you moved the task to “in pipeline” on Jira?

Checklist PR Raiser

Before creating PR
  • Have you run the tests?
  • Have you run the journey tests? (where applicable)
  • Have you run the smoke tests? (where applicable)
  • Have you run the performance tests? (where applicable)
  • Have you addressed warnings where appropriate?
  • Have you rebased against the current version of main?
  • Have you checked code coverage isn’t lower than previously?
After PRs been raised
  • Have you checked the PR Builder passes?

@platops-pr-bot
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants