PLATUI-3352: patch accessible autocomplete #430
Conversation
| @@ -27,6 +27,9 @@ | |||
| "rules": { | |||
| "import/prefer-default-export": "off" | |||
| }, | |||
| "parserOptions": { | |||
| "ecmaVersion": "latest" | |||
| }, | |||
| "overrides": [ | |||
There was a problem hiding this comment.
I think new stuff will still be transpiled away by babel, but eslint would reject using new (well supported) stuff before this - this lets us use it - would be good to review how we are bundling stuff with babel/rollup/gulp to more closely match govuk-frontend as a default so we aren't reinventing stuff if we consider them a safe default (future stuff)
| @@ -43,4 +43,4 @@ backstop_data/html_report/* | |||
|
|
|||
| webjar/ | |||
| webjar-dist/ | |||
|
|
|||
| core | |||
There was a problem hiding this comment.
when I run backstop this core file gets generated? some artifact of docker
.npmrc
Outdated
| @@ -1,2 +1 @@ | |||
| PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD=1 | |||
There was a problem hiding this comment.
now using playwright
| @@ -1,3 +1,3 @@ | |||
| module.exports = async (page, scenario, vp) => { | |||
| await require('./loadCookies')(page, scenario); | |||
| // await require('./loadCookies')(page, scenario); | |||
There was a problem hiding this comment.
not sure what this was used for, should be removed
oscarduignan
force-pushed
the
PLATUI-3352-add-fix
branch
from
56246df to
a4b7830
Compare
|
will finish this off on monday, just pushing because I want to see if playwright runs ok in build or if it fails because it's blocked - if so then we need to get it unblocked / or figure out how to get it from artifactory worked ok, just had to run |
oscarduignan
force-pushed
the
PLATUI-3352-add-fix
branch
4 times, most recently
from
74564db to
4a48ba0
Compare
oscarduignan
force-pushed
the
PLATUI-3352-integrate-fixes-from-adams-polyfill
branch
from
2bf9f07 to
96a7a94
Compare
oscarduignan
force-pushed
the
PLATUI-3352-add-fix
branch
from
4a48ba0 to
6e3113d
Compare
There was a problem hiding this comment.
I tried a few small css tweaks to fix this case, but I couldn't get anything that I was happy with that wouldn't possibly break other stuff so have left fixing this out for now - if someone has increased their base font size then the position of the dropdown arrow won't be centered
oscarduignan
force-pushed
the
PLATUI-3352-add-fix
branch
from
6e3113d to
d9cf62a
Compare
| selectElement.value = ''; | ||
| const chosenOptionOrCurrentValue = (typeof chosenOption !== 'undefined') | ||
| ? chosenOption | ||
| : document.getElementById(autocompleteId)?.value; |
There was a problem hiding this comment.
just to double check, I looked at the compiled output and ?. is not passed through, so won't be any compatibility issues by using it here
oscarduignan
dismissed
PatrykRudnicki’s stale review
The base branch was changed.
also swaps to use playwright for backstopjsbecause we needed to udpate playwright and the latest version was timing out a lot when using puppeteerplaywright already swapped in separately