Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add govuk-link style to "View the readme" links on app index page #411

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gunjam
Copy link
Contributor

@gunjam gunjam commented Oct 25, 2024

Adding missing govuk-link style to the "View the readme" on the app index page.

Preview on Firefox 131.0.3 (macOS)

Before After
image image
image image

@hmrc-web-operations
Copy link
Contributor

Thank you for submitting a pull request on this HMRC repository. A member of the HMRC team will review your changes and action accordingly.

HMRC reviewer: please reference this runbook for guidance on how to proceed.

@oscarduignan
Copy link
Contributor

Hey @gunjam apologies for the slow response to this, thank you very much for the contributions. I've checked with other maintainers and we're going to get your changes integrated. We'll probably create a new PR that combines all your PRs into one release, update/add visual regression tests, and make sure you're attributed

@gunjam
Copy link
Contributor Author

gunjam commented Dec 2, 2024

Cool, lemme know if there's anything I can do to make it easier - rebase them all, cherry-pick them onto the same branch or whatever. Ta.

@JoPintoPaul
Copy link
Contributor

Hi @gunjam , we're preparing your PRs as a single new release of hmrc-frontend now. Can you let me know your full name + Government department so we can credit you correctly in the release notes? Many thanks.

@gunjam
Copy link
Contributor Author

gunjam commented Dec 13, 2024

Hey, just including my @ will be fine, ta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants