Sign out baseline (#414)

* changing govuk header line-height values to unitless values and ensuring baseline matches GOV.UK logo and service name * Approve backstop images * release and changelog
hmrc · Nov 18, 2024 · 7e15a76 · 7e15a76
1 parent b7d388c
commit 7e15a76
Show file tree

Hide file tree

Showing 17 changed files with 17 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ## [Unreleased]
 
+## [6.40.0] - 2024-11-12
+
+### Changed
+
+- Changed baseline of sign out link to match GOV.UK header logo, on mobile widths it matches service name
+
 ## [6.39.0] - 2024-11-12
 
 ### Changed
@@ -149,7 +155,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 - Marked the `currency-input` component as deprecated. This is because the `input` from `govuk-frontend` can now take in
   a prefix, and this is the new pattern for HMRC currency inputs. See more details in
-- [currency-input/README.md](/src/components/currency-input/README.md). 
+- [currency-input/README.md](/src/components/currency-input/README.md).
 
 ## [6.16.0] - 2024-04-22
 
@@ -167,7 +173,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ### Changed
 
-- Accessibility fix: ensure `outline` appears on `account-menu` submenu items in Windows High Contrast Mode using 
+- Accessibility fix: ensure `outline` appears on `account-menu` submenu items in Windows High Contrast Mode using
   `outline-offset`
 
 ## [6.13.0] - 2024-03-27
@@ -207,7 +213,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 - Added `menuButtonText` and `menuButtonLabel` params to `header` component in line with the `govuk-frontend` header
 - Removed `hmrc-header__service-name` and `hmrc-header__service-name--linked` from `header` component, to use only styles
   from `govuk-frontend`
-- Updated `hmrc-header__service-name` and `hmrc-header__service-name--linked` (for services adding manually to other 
+- Updated `hmrc-header__service-name` and `hmrc-header__service-name--linked` (for services adding manually to other
   components)
 
 ## [6.7.0] - 2024-03-19
@@ -226,7 +232,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ### Changed
 
-- Split out [MAINTAINERS info](MAINTAINERS.md) from general [CONTRIBUTING guide](CONTRIBUTING.md) 
+- Split out [MAINTAINERS info](MAINTAINERS.md) from general [CONTRIBUTING guide](CONTRIBUTING.md)
 - Documented patch release process
 
 ## [6.4.0] - 2024-03-11
@@ -359,7 +365,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 ### Changed
 
 - Modify the timeout dialog to take in an optional parameter to not display a sign out link. This feature was proposed by
-  DWP Access to Work as cross-Government request: https://github.com/hmrc/hmrc-frontend/issues/316 
+  DWP Access to Work as cross-Government request: https://github.com/hmrc/hmrc-frontend/issues/316
 
 ## [5.51.0] - 2023-10-24
 

diff --git a/..._reference/backstop_default_header_sign_out_link_example_0_document_0_phone.png b/..._reference/backstop_default_header_sign_out_link_example_0_document_0_phone.png
diff --git a/...reference/backstop_default_header_sign_out_link_example_0_document_1_tablet.png b/...reference/backstop_default_header_sign_out_link_example_0_document_1_tablet.png
diff --git a/...e/backstop_default_header_sign_out_link_in_welsh_example_0_document_0_phone.png b/...e/backstop_default_header_sign_out_link_in_welsh_example_0_document_0_phone.png
diff --git a/.../backstop_default_header_sign_out_link_in_welsh_example_0_document_1_tablet.png b/.../backstop_default_header_sign_out_link_in_welsh_example_0_document_1_tablet.png
diff --git a/...with_custom_navigation_items_and_a_sign_out_link_example_0_document_0_phone.png b/...with_custom_navigation_items_and_a_sign_out_link_example_0_document_0_phone.png
diff --git a/...ith_custom_navigation_items_and_a_sign_out_link_example_0_document_1_tablet.png b/...ith_custom_navigation_items_and_a_sign_out_link_example_0_document_1_tablet.png
diff --git a/..._and_custom_navigation_items_and_a_sign_out_link_example_0_document_0_phone.png b/..._and_custom_navigation_items_and_a_sign_out_link_example_0_document_0_phone.png
diff --git a/...ems_and_a_sign_out_link_example_navigation-dropdown-open_0_document_0_phone.png b/...ems_and_a_sign_out_link_example_navigation-dropdown-open_0_document_0_phone.png
diff --git a/...s_of_custom_navigation_items_and_a_sign_out_link_example_0_document_0_phone.png b/...s_of_custom_navigation_items_and_a_sign_out_link_example_0_document_0_phone.png
diff --git a/..._of_custom_navigation_items_and_a_sign_out_link_example_0_document_1_tablet.png b/..._of_custom_navigation_items_and_a_sign_out_link_example_0_document_1_tablet.png
diff --git a/...d_one_custom_navigation_item_and_a_sign_out_link_example_0_document_0_phone.png b/...d_one_custom_navigation_item_and_a_sign_out_link_example_0_document_0_phone.png
diff --git a/..._one_custom_navigation_item_and_a_sign_out_link_example_0_document_1_tablet.png b/..._one_custom_navigation_item_and_a_sign_out_link_example_0_document_1_tablet.png
diff --git a/..._and_custom_navigation_items_and_a_sign_out_link_example_0_document_0_phone.png b/..._and_custom_navigation_items_and_a_sign_out_link_example_0_document_0_phone.png
diff --git a/...and_custom_navigation_items_and_a_sign_out_link_example_0_document_1_tablet.png b/...and_custom_navigation_items_and_a_sign_out_link_example_0_document_1_tablet.png
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "hmrc-frontend",
-  "version": "6.39.0",
+  "version": "6.40.0",
   "description": "Design patterns for HMRC frontends",
   "scripts": {
     "start": "gulp dev",

diff --git a/src/components/header/_header.scss b/src/components/header/_header.scss
@@ -16,9 +16,13 @@ $govuk-header-link-underline-thickness: 3px;
   .hmrc-sign-out-nav__link {
     color: govuk-colour("white");
     font-weight: bold;
-    line-height: 1.8em;
+    line-height: 1.64285;
     text-decoration: none;
 
+    @include govuk-media-query($from: desktop) {
+      line-height: 2.375;
+    }
+
     &:hover {
       text-decoration: underline;
     }