-
Notifications
You must be signed in to change notification settings - Fork 21
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* PLATUI-2823: Update govuk-frontend to v4.8.0 to include new Tudor crown, updated header with feature flag, added new HMRC Crest Logo to banner and internal header with feature flag * PLATUI-2817: Updated PR to use old Crown by default, and only Tudor Crown when passed as param * PLATUI-2817: Bump version to 5.65.0 * PLATUI-2817: Bump version to 5.66.0 * pass through the tudor crown option in the account-header layout (#343) * fix tests, and refactor header * accept backstop changes * update tests due to change in position of banners in header * Update hmrc footer to delegate to govuk footer * update character count params with new additions * PLATUI-2847: revert back to previous structure In trying to create an example of the issue that I changed the structure to fix, I realised that the issue came not from a govuk change but from changing back to follow the govuk convention. Because of that, even though I still think it would be good to match GOV.UK - it's not worth making that change as part of this - especially because we still have the language select and sign out links within the header which mean we wouldn't be able to get rid of our fork all together. * PLATUI-2847: remove banner ref in changelog * PLATUI-2847: add back in the hmrc-header__service-name classes Noticed that this would break a few tests - now the only difference is the labels for the menu on mobile - however that is something we don't seem to have explicitly diverged on from the govuk implementation. * PLATUI-2847: remove redundant styles for hmrc-header__service-name * Revert "PLATUI-2847: remove redundant styles for hmrc-header__service-name" This reverts commit 76e5406. * PLATUI-2847: remove IE8 fallbacks and shorten svg tests --------- Co-authored-by: JoPintoPaul <[email protected]> Co-authored-by: Kyle Bowden <[email protected]>
- Loading branch information
1 parent
26b50b3
commit 1b2084f
Showing
142 changed files
with
759 additions
and
584 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+42.7 KB
...nt-header_all-available-options-with-tudor-crown_example_0_document_0_phone.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+55.1 KB
...t-header_all-available-options-with-tudor-crown_example_0_document_1_tablet.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-173 Bytes
(100%)
...top_default_account-header_all-available-options_example_0_document_0_phone.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-89 Bytes
(100%)
...op_default_account-header_all-available-options_example_0_document_1_tablet.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-136 Bytes
(100%)
...eference/backstop_default_account-header_default_example_0_document_0_phone.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-68 Bytes
(100%)
...ference/backstop_default_account-header_default_example_0_document_1_tablet.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-172 Bytes
(100%)
...kstop_default_account-header_global-service-name_example_0_document_0_phone.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-70 Bytes
(100%)
...stop_default_account-header_global-service-name_example_0_document_1_tablet.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-89 Bytes
(100%)
...p_default_account-header_link-states-on-desktop_example_0_document_0_tablet.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-75 Bytes
(100%)
...es-on-desktop_example_account-menu-account-home-focused_0_document_0_tablet.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-80 Bytes
(100%)
...es-on-desktop_example_account-menu-account-home-hovered_0_document_0_tablet.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-95 Bytes
(100%)
...states-on-desktop_example_account-menu-messages-focused_0_document_0_tablet.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-82 Bytes
(100%)
...states-on-desktop_example_account-menu-messages-hovered_0_document_0_tablet.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-48 Bytes
(100%)
...-select-alternate-lang-focused-and-current-lang-hovered_0_document_0_tablet.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1.14 KB
(98%)
...-select-current-lang-focused-and-alternate-lang-hovered_0_document_0_tablet.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-172 Bytes
(100%)
..._link-states-on-mobile-with-dropdown-link-active_example_0_document_0_phone.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-111 Bytes
(100%)
...e_example_account-menu-dropdown-open-active-link-focused_0_document_0_phone.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-118 Bytes
(100%)
...e_example_account-menu-dropdown-open-active-link-hovered_0_document_0_phone.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-118 Bytes
(100%)
...-dropdown-link-active_example_account-menu-dropdown-open_0_document_0_phone.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-140 Bytes
(100%)
...ink-active_example_account-menu-with-larger-browser-font_0_document_0_phone.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-173 Bytes
(100%)
...top_default_account-header_link-states-on-mobile_example_0_document_0_phone.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-122 Bytes
(100%)
...ates-on-mobile_example_account-menu-account-home-focused_0_document_0_phone.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-170 Bytes
(100%)
...ates-on-mobile_example_account-menu-account-home-hovered_0_document_0_phone.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-123 Bytes
(100%)
...k-states-on-mobile_example_account-menu-dropdown-focused_0_document_0_phone.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-171 Bytes
(100%)
...k-states-on-mobile_example_account-menu-dropdown-hovered_0_document_0_phone.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-111 Bytes
(100%)
...bile_example_account-menu-dropdown-open-messages-focused_0_document_0_phone.png
Oops, something went wrong.
Binary file modified
BIN
-119 Bytes
(100%)
...bile_example_account-menu-dropdown-open-messages-hovered_0_document_0_phone.png
Oops, something went wrong.
Binary file modified
BIN
-119 Bytes
(100%)
...link-states-on-mobile_example_account-menu-dropdown-open_0_document_0_phone.png
Oops, something went wrong.
Binary file modified
BIN
-117 Bytes
(100%)
...lt_account-header_overridden-global-service-name_example_0_document_0_phone.png
Oops, something went wrong.
Binary file modified
BIN
-54 Bytes
(100%)
...t_account-header_overridden-global-service-name_example_0_document_1_tablet.png
Oops, something went wrong.
Binary file modified
BIN
-109 Bytes
(100%)
...p_default_account-header_welsh-with-service-name_example_0_document_0_phone.png
Oops, something went wrong.
Binary file modified
BIN
-71 Bytes
(100%)
..._default_account-header_welsh-with-service-name_example_0_document_1_tablet.png
Oops, something went wrong.
Binary file modified
BIN
-199 Bytes
(100%)
...ackstop_default_account-header_with-service-name_example_0_document_0_phone.png
Oops, something went wrong.
Binary file modified
BIN
-65 Bytes
(100%)
...ckstop_default_account-header_with-service-name_example_0_document_1_tablet.png
Oops, something went wrong.
Binary file modified
BIN
-40 Bytes
(100%)
...reference/backstop_default_add-to-a-list_default_example_0_document_0_phone.png
Oops, something went wrong.
Binary file modified
BIN
+17 Bytes
(100%)
...eference/backstop_default_add-to-a-list_default_example_0_document_1_tablet.png
Oops, something went wrong.
Binary file modified
BIN
-4 Bytes
(100%)
.../backstop_default_add-to-a-list_empty-list-welsh_example_0_document_0_phone.png
Oops, something went wrong.
Binary file modified
BIN
+20 Bytes
(100%)
...backstop_default_add-to-a-list_empty-list-welsh_example_0_document_1_tablet.png
Oops, something went wrong.
Binary file modified
BIN
+13 Bytes
(100%)
...fault_add-to-a-list_multiple-generic-welsh-items_example_0_document_0_phone.png
Oops, something went wrong.
Binary file modified
BIN
+5 Bytes
(100%)
...ault_add-to-a-list_multiple-generic-welsh-items_example_0_document_1_tablet.png
Oops, something went wrong.
Binary file modified
BIN
+3 Bytes
(100%)
...op_default_add-to-a-list_multiple-specific-items_example_0_document_0_phone.png
Oops, something went wrong.
Binary file modified
BIN
+36 Bytes
(100%)
...p_default_add-to-a-list_multiple-specific-items_example_0_document_1_tablet.png
Oops, something went wrong.
Binary file modified
BIN
-37 Bytes
(100%)
...ckstop_default_add-to-a-list_single-generic-item_example_0_document_0_phone.png
Oops, something went wrong.
Binary file modified
BIN
+25 Bytes
(100%)
...kstop_default_add-to-a-list_single-generic-item_example_0_document_1_tablet.png
Oops, something went wrong.
Binary file modified
BIN
-15 Bytes
(100%)
..._default_add-to-a-list_single-generic-welsh-item_example_0_document_0_phone.png
Oops, something went wrong.
Binary file modified
BIN
+6 Bytes
(100%)
...default_add-to-a-list_single-generic-welsh-item_example_0_document_1_tablet.png
Oops, something went wrong.
Binary file modified
BIN
+56 Bytes
(100%)
...itmaps_reference/backstop_default_banner_default_example_0_document_0_phone.png
Oops, something went wrong.
Binary file modified
BIN
+22 Bytes
(100%)
...tmaps_reference/backstop_default_banner_default_example_0_document_1_tablet.png
Oops, something went wrong.
Binary file modified
BIN
-90 Bytes
(98%)
.../bitmaps_reference/backstop_default_banner_welsh_example_0_document_0_phone.png
Oops, something went wrong.
Binary file modified
BIN
-64 Bytes
(99%)
...bitmaps_reference/backstop_default_banner_welsh_example_0_document_1_tablet.png
Oops, something went wrong.
Binary file added
BIN
+5.54 KB
...ce/backstop_default_banner_with-st-edwards-crown_example_0_document_0_phone.png
Oops, something went wrong.
Binary file added
BIN
+9.44 KB
...e/backstop_default_banner_with-st-edwards-crown_example_0_document_1_tablet.png
Oops, something went wrong.
Binary file added
BIN
+5.47 KB
...ference/backstop_default_banner_with-tudor-crown_example_0_document_0_phone.png
Oops, something went wrong.
Binary file added
BIN
+9.33 KB
...erence/backstop_default_banner_with-tudor-crown_example_0_document_1_tablet.png
Oops, something went wrong.
Binary file modified
BIN
+515 Bytes
(100%)
...aracter-count_with_default_value_exceeding_limit_example_0_document_0_phone.png
Oops, something went wrong.
Binary file modified
BIN
+207 Bytes
(100%)
...racter-count_with_default_value_exceeding_limit_example_0_document_1_tablet.png
Oops, something went wrong.
Binary file modified
BIN
+407 Bytes
(100%)
...r-count_with_default_value_exceeding_limit_welsh_example_0_document_0_phone.png
Oops, something went wrong.
Binary file modified
BIN
+217 Bytes
(100%)
...-count_with_default_value_exceeding_limit_welsh_example_0_document_1_tablet.png
Oops, something went wrong.
Binary file added
BIN
+30.8 KB
...efault_footer_with_params_common_to_govuk_footer_example_0_document_0_phone.png
Oops, something went wrong.
Binary file added
BIN
+36.8 KB
...fault_footer_with_params_common_to_govuk_footer_example_0_document_1_tablet.png
Oops, something went wrong.
Binary file modified
BIN
-203 Bytes
(99%)
...itmaps_reference/backstop_default_header_default_example_0_document_0_phone.png
Oops, something went wrong.
Binary file modified
BIN
-203 Bytes
(99%)
...tmaps_reference/backstop_default_header_default_example_0_document_1_tablet.png
Oops, something went wrong.
Binary file modified
BIN
-123 Bytes
(98%)
...aps_reference/backstop_default_header_full_width_example_0_document_0_phone.png
Oops, something went wrong.
Binary file modified
BIN
-97 Bytes
(99%)
...ps_reference/backstop_default_header_full_width_example_0_document_1_tablet.png
Oops, something went wrong.
Binary file modified
BIN
-178 Bytes
(99%)
...ll_width_with_navigation_and_menu_open_on_mobile_example_0_document_0_phone.png
Oops, something went wrong.
Binary file modified
BIN
-148 Bytes
(98%)
...ckstop_default_header_full_width_with_navigation_example_0_document_0_phone.png
Oops, something went wrong.
Binary file modified
BIN
-153 Bytes
(99%)
...kstop_default_header_full_width_with_navigation_example_0_document_1_tablet.png
Oops, something went wrong.
Binary file modified
BIN
-164 Bytes
(98%)
...ackstop_default_header_navigation_item_with_html_example_0_document_0_phone.png
Oops, something went wrong.
Binary file modified
BIN
-22 Bytes
(100%)
...ckstop_default_header_navigation_item_with_html_example_0_document_1_tablet.png
Oops, something went wrong.
Binary file modified
BIN
-164 Bytes
(98%)
...lt_header_navigation_item_with_html_without_link_example_0_document_0_phone.png
Oops, something went wrong.
Binary file modified
BIN
-32 Bytes
(100%)
...t_header_navigation_item_with_html_without_link_example_0_document_1_tablet.png
Oops, something went wrong.
Binary file modified
BIN
-164 Bytes
(98%)
...lt_header_navigation_item_with_text_without_link_example_0_document_0_phone.png
Oops, something went wrong.
Binary file modified
BIN
-27 Bytes
(100%)
...t_header_navigation_item_with_text_without_link_example_0_document_1_tablet.png
Oops, something went wrong.
Binary file modified
BIN
-122 Bytes
(99%)
..._reference/backstop_default_header_sign_out_link_example_0_document_0_phone.png
Oops, something went wrong.
Binary file modified
BIN
-98 Bytes
(99%)
...reference/backstop_default_header_sign_out_link_example_0_document_1_tablet.png
Oops, something went wrong.
Binary file modified
BIN
-127 Bytes
(99%)
...e/backstop_default_header_sign_out_link_in_welsh_example_0_document_0_phone.png
Oops, something went wrong.
Binary file modified
BIN
-146 Bytes
(99%)
.../backstop_default_header_sign_out_link_in_welsh_example_0_document_1_tablet.png
Oops, something went wrong.
Binary file modified
BIN
-209 Bytes
(99%)
...e/backstop_default_header_with_additional_banner_example_0_document_0_phone.png
Oops, something went wrong.
Binary file modified
BIN
-118 Bytes
(99%)
.../backstop_default_header_with_additional_banner_example_0_document_1_tablet.png
Oops, something went wrong.
Binary file modified
BIN
-203 Bytes
(99%)
...backstop_default_header_with_hmrc_banner_english_example_0_document_0_phone.png
Oops, something went wrong.
Binary file modified
BIN
-180 Bytes
(99%)
...ackstop_default_header_with_hmrc_banner_english_example_0_document_1_tablet.png
Oops, something went wrong.
Binary file modified
BIN
-220 Bytes
(98%)
...e/backstop_default_header_with_hmrc_banner_welsh_example_0_document_0_phone.png
Oops, something went wrong.
Binary file modified
BIN
-173 Bytes
(99%)
.../backstop_default_header_with_hmrc_banner_welsh_example_0_document_1_tablet.png
Oops, something went wrong.
Binary file modified
BIN
-119 Bytes
(99%)
...stop_default_header_with_language_toggle_english_example_0_document_0_phone.png
Oops, something went wrong.
Binary file modified
BIN
-156 Bytes
(99%)
...top_default_header_with_language_toggle_english_example_0_document_1_tablet.png
Oops, something went wrong.
Binary file modified
BIN
-127 Bytes
(99%)
...ckstop_default_header_with_language_toggle_welsh_example_0_document_0_phone.png
Oops, something went wrong.
Binary file modified
BIN
-140 Bytes
(99%)
...kstop_default_header_with_language_toggle_welsh_example_0_document_1_tablet.png
Oops, something went wrong.
Binary file modified
BIN
-163 Bytes
(97%)
...ce/backstop_default_header_with_large_navigation_example_0_document_0_phone.png
Oops, something went wrong.
Binary file modified
BIN
+15 Bytes
(100%)
...e/backstop_default_header_with_large_navigation_example_0_document_1_tablet.png
Oops, something went wrong.
Binary file modified
BIN
-162 Bytes
(99%)
...kstop_default_header_with_large_navigation_welsh_example_0_document_0_phone.png
Oops, something went wrong.
Binary file modified
BIN
-60 Bytes
(100%)
...stop_default_header_with_large_navigation_welsh_example_0_document_1_tablet.png
Oops, something went wrong.
Binary file modified
BIN
-163 Bytes
(97%)
...eference/backstop_default_header_with_navigation_example_0_document_0_phone.png
Oops, something went wrong.
Binary file modified
BIN
-211 Bytes
(99%)
...ference/backstop_default_header_with_navigation_example_0_document_1_tablet.png
Oops, something went wrong.
Binary file modified
BIN
-151 Bytes
(98%)
...ce/backstop_default_header_with_navigation_welsh_example_0_document_0_phone.png
Oops, something went wrong.
Binary file modified
BIN
-211 Bytes
(99%)
...e/backstop_default_header_with_navigation_welsh_example_0_document_1_tablet.png
Oops, something went wrong.
Binary file added
BIN
+9.02 KB
...efault_header_with_params_common_to_govuk_header_example_0_document_0_phone.png
Oops, something went wrong.
Binary file added
BIN
+18.5 KB
...fault_header_with_params_common_to_govuk_header_example_0_document_1_tablet.png
Oops, something went wrong.
Binary file modified
BIN
-124 Bytes
(98%)
...erence/backstop_default_header_with_product_name_example_0_document_0_phone.png
Oops, something went wrong.
Binary file modified
BIN
-99 Bytes
(99%)
...rence/backstop_default_header_with_product_name_example_0_document_1_tablet.png
Oops, something went wrong.
Binary file modified
BIN
-164 Bytes
(98%)
..._default_header_with_service_name_and_navigation_example_0_document_0_phone.png
Oops, something went wrong.
Binary file modified
BIN
-21 Bytes
(100%)
...default_header_with_service_name_and_navigation_example_0_document_1_tablet.png
Oops, something went wrong.
Binary file modified
BIN
-115 Bytes
(98%)
...ult_header_with_service_name_but_no_service_link_example_0_document_0_phone.png
Oops, something went wrong.
Binary file modified
BIN
-17 Bytes
(100%)
...lt_header_with_service_name_but_no_service_link_example_0_document_1_tablet.png
Oops, something went wrong.
Binary file modified
BIN
-115 Bytes
(98%)
...erence/backstop_default_header_with_service_name_example_0_document_0_phone.png
Oops, something went wrong.
Binary file modified
BIN
-17 Bytes
(100%)
...rence/backstop_default_header_with_service_name_example_0_document_1_tablet.png
Oops, something went wrong.
Binary file added
BIN
+22.4 KB
...ce/backstop_default_header_with_st_edwards_crown_example_0_document_0_phone.png
Oops, something went wrong.
Binary file added
BIN
+30.2 KB
...e/backstop_default_header_with_st_edwards_crown_example_0_document_1_tablet.png
Oops, something went wrong.
Binary file added
BIN
+23 KB
...ference/backstop_default_header_with_tudor_crown_example_0_document_0_phone.png
Oops, something went wrong.
Binary file added
BIN
+31.1 KB
...erence/backstop_default_header_with_tudor_crown_example_0_document_1_tablet.png
Oops, something went wrong.
Binary file modified
BIN
-96 Bytes
(99%)
...ference/backstop_default_internal-header_default_example_0_document_0_phone.png
Oops, something went wrong.
Binary file modified
BIN
-146 Bytes
(99%)
...erence/backstop_default_internal-header_default_example_0_document_1_tablet.png
Oops, something went wrong.
Binary file modified
BIN
-200 Bytes
(97%)
...reference/backstop_default_internal-header_welsh_example_0_document_0_phone.png
Oops, something went wrong.
Binary file modified
BIN
-143 Bytes
(99%)
...eference/backstop_default_internal-header_welsh_example_0_document_1_tablet.png
Oops, something went wrong.
Binary file modified
BIN
-100 Bytes
(99%)
...ckstop_default_internal-header_with-service-name_example_0_document_0_phone.png
Oops, something went wrong.
Binary file modified
BIN
-183 Bytes
(99%)
...kstop_default_internal-header_with-service-name_example_0_document_1_tablet.png
Oops, something went wrong.
Binary file added
BIN
+7.18 KB
...op_default_internal-header_with-st-edwards-crown_example_0_document_0_phone.png
Oops, something went wrong.
Binary file added
BIN
+10.7 KB
...p_default_internal-header_with-st-edwards-crown_example_0_document_1_tablet.png
Oops, something went wrong.
Binary file added
BIN
+6.87 KB
...ackstop_default_internal-header_with-tudor-crown_example_0_document_0_phone.png
Oops, something went wrong.
Binary file added
BIN
+10.6 KB
...ckstop_default_internal-header_with-tudor-crown_example_0_document_1_tablet.png
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.