Skip to content

Commit

Permalink
Merge pull request #18 from hmrc/develop
Browse files Browse the repository at this point in the history
Release v0.4.0
  • Loading branch information
TheNickWilson authored Dec 21, 2017
2 parents be67742 + ba807d6 commit bd40734
Show file tree
Hide file tree
Showing 6 changed files with 29 additions and 14 deletions.
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,13 @@ All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).

## v0.4.0 - 2017-12-21

### Changed
* Radio and yes/no components to use new markup
* Assets frontend version to 3.0.1
* Default heading class to heading-xlarge

## v0.3.0 - 2017-12-06

### Added
Expand Down
4 changes: 2 additions & 2 deletions src/main/g8/app/views/components/heading.scala.html
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
@(headingKey: String, headingSize: String = "heading-medium")(implicit messages: Messages)
@(headingKey: String, headingSize: String = "heading-xlarge")(implicit messages: Messages)

<h1 class="@headingSize">@messages(headingKey)</h1>
<h1 class="@headingSize">@messages(headingKey)</h1>
11 changes: 7 additions & 4 deletions src/main/g8/app/views/components/input_radio.scala.html
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,13 @@
}
</legend>
@for(input <- inputs) {
<label class="block-label selection-button-radio" for="@{input.id}">
<input id="@{input.id}" type="radio" name="@{field.name}" value="@{input.value}" @if(field.value == Some(input.value)){checked="checked"} @if(trackGa){data-journey-click="$name$:click:@{input.id}"} />
@messages(input.messageKey)
</label>
<div class="multiple-choice">
<input id="@{input.id}" type="radio" name="@{field.id}" value="@{input.value}" @if(field.value == Some(input.value)){checked="checked"} @if(trackGa){data-journey-click="$name$:click:@{input.id}"} />

<label class="block-label selection-button-radio" for="@{input.id}">
@messages(input.messageKey)
</label>
</div>
}
</fieldset>
</div>
17 changes: 11 additions & 6 deletions src/main/g8/app/views/components/input_yes_no.scala.html
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,19 @@
<span class="error-notification" id="error-message-@{field.id}-input">@messages(error.message, error.args: _*)</span>
}
</legend>
<label class="block-label selection-button-radio" for="@{field.id}-yes" data-target="@if(yesAssoc.nonEmpty){@yesAssoc}">
<div class="multiple-choice">
<input id="@{field.id}-yes" type="radio" name="@{field.id}" value="true" @if(field.value.contains("true")){checked="checked"} />
@messages("site.yes")
</label>
<label class="block-label selection-button-radio" for="@{field.id}-no" data-target="@if(noAssoc.nonEmpty){@noAssoc}">
<label class="block-label selection-button-radio" for="@{field.id}-yes" data-target="@if(yesAssoc.nonEmpty){@yesAssoc}">
@messages("site.yes")
</label>
</div>

<div class="multiple-choice">
<input id="@{field.id}-no" type="radio" name="@{field.id}" value="false" @if(field.value.contains("false")){checked="checked"} />
@messages("site.no")
</label>
<label class="block-label selection-button-radio" for="@{field.id}-no" data-target="@if(noAssoc.nonEmpty){@noAssoc}">
@messages("site.no")
</label>
</div>

</fieldset>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/main/g8/conf/application.conf
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ google-analytics {
}

assets {
version = "2.247.0"
version = "3.0.1"
version = \${?ASSETS_FRONTEND_VERSION}
url = "http://localhost:9032/assets/"
}
Expand Down
2 changes: 1 addition & 1 deletion src/main/g8/project/build.properties
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
sbt.version=0.13.15
hmrc-frontend-scaffold.version=0.3.0
hmrc-frontend-scaffold.version=0.4.0

0 comments on commit bd40734

Please sign in to comment.