GFORMS-1662 - Page NotFound error message in kibana log after new rel…

…ease (#1415)
hmrc · Jan 27, 2022 · ce9b85a · ce9b85a
1 parent 6f7bce7
commit ce9b85a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/app/uk/gov/hmrc/gform/controllers/ErrResponder.scala b/app/uk/gov/hmrc/gform/controllers/ErrResponder.scala
@@ -125,7 +125,7 @@ class ErrResponder(
     requestHeader: RequestHeader,
     message: String,
     maybeFormTemplate: Option[FormTemplate],
-    smartLogger: SmartLogger = smartLocalLogger
+    smartLogger: SmartLogger
   ): Future[Result] = {
     val l: LangADT = LangADT.fromRequest(requestHeader, langs)
     smartLogger.log(s"Bad request: $message")

diff --git a/app/uk/gov/hmrc/gform/controllers/ErrorHandler.scala b/app/uk/gov/hmrc/gform/controllers/ErrorHandler.scala
@@ -36,17 +36,18 @@ class ErrorHandler(
     extends DefaultHttpErrorHandler(environment, configuration, sourceMapper, None) {
 
   private val smartUpstreamLogger = SmartLogger.upstreamLogger
+  private val smartLocalLogger = SmartLogger.localLogger
 
   override protected def onBadRequest(
     requestHeader: RequestHeader,
     message: String
-  ): Future[Result] = errResponder.badRequest(requestHeader, message, None)
+  ): Future[Result] = errResponder.badRequest(requestHeader, message, None, smartLocalLogger)
 
   override protected def onNotFound(
     requestHeader: RequestHeader,
     message: String
   ): Future[Result] =
-    errResponder.notFound(requestHeader, message, None, smartUpstreamLogger)
+    errResponder.notFound(requestHeader, message, None, smartLocalLogger)
 
   override protected def onOtherClientError(
     requestHeader: RequestHeader,
@@ -59,7 +60,6 @@ class ErrorHandler(
     maybeFormTemplate.flatMap(maybeFormTemplate =>
       errResponder.onOtherClientError(requestHeader, statusCode, message, maybeFormTemplate)
     )
-
   }
 
   override def onServerError(requestHeader: RequestHeader, exception: Throwable): Future[Result] = {
@@ -75,8 +75,7 @@ class ErrorHandler(
         case UpstreamErrorResponse.WithStatusCode(statusCode, e) if statusCode == BadRequest.intValue =>
           errResponder.badRequest(requestHeader, e.message, maybeFormTemplate, smartUpstreamLogger)
         case e: BadRequestException =>
-          errResponder.badRequest(requestHeader, e.message, maybeFormTemplate)
-        //    case e: UnauthorizedException => TODO redirect to login page
+          errResponder.badRequest(requestHeader, e.message, maybeFormTemplate, smartLocalLogger)
         case UpstreamErrorResponse.WithStatusCode(statusCode, e) if statusCode == Forbidden.intValue =>
           errResponder.forbidden(e.message, maybeFormTemplate, None, smartUpstreamLogger)(requestHeader)
         case e: ForbiddenException =>