-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EMCS-716 (DraftSubmissionController and User Details for Message Submitted) #251
Open
RobertLaverick
wants to merge
17
commits into
main
Choose a base branch
from
EMCS-716-b
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
RobertLaverick
commented
Dec 5, 2024
- We had a note about testing if the audit service returns a future failed. Looking at the library code that isn’t possible as they silently absorb all throwable and turn them into an AuditResult.Failure.
- I feel like I’ve lost my mind over whether or not just calling a def with an EitherT will run it, or if you have to force it to resolve with a map/for-yield/value call. Please check this.
- On reflection, we could probably benefit from having the audit events called in the service layer. (i.e. MessageSubmitted events all come from submitMessageService, regardless of saving successfully or not) - maybe a refactoring ticket when we drop the old audit events.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.