Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMCS-716 (DraftSubmissionController and User Details for Message Submitted) #251

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

RobertLaverick
Copy link
Contributor

  • We had a note about testing if the audit service returns a future failed. Looking at the library code that isn’t possible as they silently absorb all throwable and turn them into an AuditResult.Failure.
  • I feel like I’ve lost my mind over whether or not just calling a def with an EitherT will run it, or if you have to force it to resolve with a map/for-yield/value call. Please check this.
  • On reflection, we could probably benefit from having the audit events called in the service layer. (i.e. MessageSubmitted events all come from submitMessageService, regardless of saving successfully or not) - maybe a refactoring ticket when we drop the old audit events.

@platops-pr-bot
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants