DTSPO-18332 - Simplify onboarding to persistent preview databases #5892
+106
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louisehuyton
requested review from
a team,
cpareek,
Tyler-35,
JordanHoey96 and
ieuanb74
and removed request for
a team
thomast1906
reviewed
Dec 16, 2024
bin/v2/postgres-setup.sh
Outdated
| version: "14" | ||
| network: | ||
| delegatedSubnetResourceReference: | ||
| armId: /subscriptions/8b6ea922-0862-443e-af15-6056e1c9b9a4/resourceGroups/cft-preview-network-rg/providers/Microsoft.Network/virtualNetworks/cft-preview-vnet/subnets/postgresql |
There was a problem hiding this comment.
oops should be sds, changing now
thomast1906
reviewed
Dec 16, 2024
bin/v2/postgres-setup.sh
Outdated
| name: ${NAMESPACE}-${ENVIRONMENT} | ||
| namespace: ${NAMESPACE} | ||
| spec: | ||
| version: "14" |
There was a problem hiding this comment.
would version 16 be more suitable @thomast1906?
thomast1906
reviewed
Dec 16, 2024
bin/v2/postgres-setup.sh
Outdated
| privateDnsZoneArmResourceReference: | ||
| armId: /subscriptions/1baf5470-1c3e-40d3-a6f7-74bfbce4b348/resourceGroups/core-infra-intsvc-rg/providers/Microsoft.Network/privateDnsZones/privatelink.postgres.database.azure.com | ||
| EOF | ||
| ) >"apps/$NAMESPACE_NAME/preview/aso/$NAMESPACE_NAME-postgres.yaml" |
There was a problem hiding this comment.
changed to dev locally, will push in a sec once i correct the other above changes
thomast1906
requested changes
Dec 16, 2024
thomast1906
reviewed
Dec 16, 2024
|
|
||
| ( | ||
| cat <<EOF | ||
| apiVersion: dbforpostgresql.azure.com/v1api20210601 |
thomast1906
reviewed
Dec 16, 2024
|
|
||
| ( | ||
| cat <<EOF | ||
| apiVersion: dbforpostgresql.azure.com/v1api20210601 |
|
Can you update/confirm the testing that has been done as part of PR? I also think its missing documentation on how to use etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira link
DTSPO-18332
Change description
Simplify onboarding to persistent preview databases
Testing done
Checklist
🤖AEP PR SUMMARY🤖
md
postgres-setup.shwhich contains a script for setting up Postgres, creating ASO and sops-secrets, and installing Sops if not installed