Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ops/dtspo 22513/sds jenkins #5887

Merged
merged 4 commits into from
Dec 17, 2024
Merged

Ops/dtspo 22513/sds jenkins #5887

merged 4 commits into from
Dec 17, 2024

Conversation

jordankainos
Copy link
Contributor

@jordankainos jordankainos commented Dec 16, 2024 •
edited by github-actions bot
Loading

Jira link

See PROJ-XXXXXX

Change description

Testing done

Checklist

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)
  • Does this PR introduce a breaking change

🤖AEP PR SUMMARY🤖

  • File: apps/jenkins/jenkins/ptlsbox/disk.yaml
  • Updated the diskName from "sds-jenkins-ptlsbox-disk" to "sds-jenkins-ptlsbox-disk-standard"
  • Updated the diskURI accordingly

@jordankainos jordankainos requested a review from a team as a code owner December 16, 2024 09:17
thomast1906
thomast1906 reviewed Dec 16, 2024
View reviewed changes
apps/jenkins/jenkins/ptlsbox/disk.yaml Outdated
@@ -5,5 +5,5 @@ metadata:
namespace: jenkins
spec:
azureDisk:
diskName: sds-jenkins-ptlsbox-disk
diskName: sds-jenkins-ptlsbox-disk-standard
diskURI: /subscriptions/64b1c6d6-1481-44ad-b620-d8fe26a2c768/resourceGroups/disks-ptlsbox-rg/providers/Microsoft.Compute/disks/sds-jenkins-ptlsbox-disk
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disk URI ?

thomast1906
thomast1906 requested changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@thomast1906 thomast1906 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review comment

@jordankainos jordankainos merged commit 02437f1 into master Dec 17, 2024
18 checks passed
@jordankainos jordankainos deleted the OPS/DTSPO-22513/sds-jenkins branch December 17, 2024 08:15
jordankainos added a commit that referenced this pull request Dec 17, 2024
@jordankainos
Revert "Ops/dtspo 22513/sds jenkins (#5887)"
e6ddb8d 
This reverts commit 02437f1.
@jordankainos jordankainos mentioned this pull request Dec 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomast1906 thomast1906 thomast1906 approved these changes

@c4seyla c4seyla Awaiting requested review from c4seyla c4seyla is a code owner automatically assigned from hmcts/platform-operations

@roycohen1 roycohen1 Awaiting requested review from roycohen1 roycohen1 is a code owner automatically assigned from hmcts/platform-operations

@ConnorOKane-Kainos ConnorOKane-Kainos Awaiting requested review from ConnorOKane-Kainos ConnorOKane-Kainos is a code owner automatically assigned from hmcts/platform-operations

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jordankainos @thomast1906